harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: svn commit: r807222 - in /harmony/enhanced/classlib/trunk/modules/luni/make: exclude.zos.s390.ibm exclude.zos.s390x.ibm
Date Tue, 25 Aug 2009 17:44:54 GMT
On 24/Aug/2009 15:40, Mark Hindess wrote:
> In message <25aac9fc0908240726v15a55632u1bb5bd3581a0b6d3@mail.gmail.com>,
> sebb writes:
>> Comment from the peanut gallery - why not create an SVN branch or tag
>> when you do a code freeze? That would avoid accidents.
> 
> Good question.
> 
> I don't recall why we adopted the current process but:
> 
> 1) it has worked 10 times before without accidents so I expected it to
>    work this time, and
> 
> 2) I assume that if people can't commit new code then they might spend
>    their time testing the code instead.

Yeah, this was the main reason.  Everyone is supposedly focused on
achieving the milestone.  If a committer has a burning desire to do
their own thing then they can create a working branch, but the
preference is that all hands on deck to stabilize, test, and release the
 milestone.

Regards,
Tim

>> SVN tags and branches are very cheap to create.
> 
> Indeed.
> 
> Regards,
>  Mark.
> 
>> On 24/08/2009, Mark Hindess <mark.hindess@googlemail.com> wrote:
>>>  In message <4A929FE4.4010506@googlemail.com>, Oliver Deakin writes:
>>>  >
>>>  > Hi all,
>>>  >
>>>  > I mistakenly committed the below just now thinking it would not effect
>>>  > the milestone build/code freeze, as it is a test exclude file for z/OS
>>>  > which is not one of the platforms we milestone. Mark has just contacted
>>>  > me pointing out that we package the test exclude files now as part of
>>>  > the HDK, so this should not have been committed in the code freeze.
>>>  > Apologies for the commit - I am happy to revert the change if anyone
>>>  > feels strongly about it?
>>>
>>>
>>> I would not have approved this but it might as well stay now.
>>>  -Mark.
>>>
>>>
>>>  > odeakin@apache.org wrote:
>>>  > > Author: odeakin
>>>  > > Date: Mon Aug 24 14:03:07 2009
>>>  > > New Revision: 807222
>>>  > >
>>>  > > URL: http://svn.apache.org/viewvc?rev=807222&view=rev
>>>  > > Log:
>>>  > > Remove excludes for Double/FloatTest on z/OS since Kevin's commit
at r
>> 80642
>>>  > 4 has fixed these failures.
>>>  > >
>>>  > > Modified:
>>>  > >     harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zos.s390
>> .ibm
>>>  > >     harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zos.s390
>> x.ibm
>>>  > >
>>>  > > Modified: harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zo
>> s.s39
>>>  > 0.ibm
>>>  > > URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modu
>> les/l
>>>  > uni/make/exclude.zos.s390.ibm?rev=807222&r1=807221&r2=807222&view=diff
>>>  > > ======================================================================
>> =====
>>>  > ===
>>>  > > --- harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zos.s390
>> .ibm
>>>  > (original)
>>>  > > +++ harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zos.s390
>> .ibm
>>>  > Mon Aug 24 14:03:07 2009
>>>  > > @@ -2,5 +2,3 @@
>>>  > >  org/apache/harmony/luni/tests/java/lang/SecurityManager2Test.java
>>>  > >  org/apache/harmony/luni/tests/java/lang/PackageTest.java
>>>  > >  org/apache/harmony/luni/tests/java/net/InetAddressTest.java
>>>  > > -org/apache/harmony/luni/tests/java/lang/DoubleTest.java
>>>  > > -org/apache/harmony/luni/tests/java/lang/FloatTest.java
>>>  > >
>>>  > > Modified: harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zo
>> s.s39
>>>> 0x.ibm
>>>>> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modul
>> es/l
>>>> uni/make/exclude.zos.s390x.ibm?rev=807222&r1=807221&r2=807222&view=diff
>>>  > > ======================================================================
>> =====
>>>  > ===
>>>  > > --- harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zos.s390
>> x.ibm
>>>  >  (original)
>>>  > > +++ harmony/enhanced/classlib/trunk/modules/luni/make/exclude.zos.s390
>> x.ibm
>>>  >  Mon Aug 24 14:03:07 2009
>>>  > > @@ -2,5 +2,3 @@
>>>  > >  org/apache/harmony/luni/tests/java/lang/SecurityManager2Test.java
>>>  > >  org/apache/harmony/luni/tests/java/lang/PackageTest.java
>>>  > >  org/apache/harmony/luni/tests/java/net/InetAddressTest.java
>>>  > > -org/apache/harmony/luni/tests/java/lang/DoubleTest.java
>>>  > > -org/apache/harmony/luni/tests/java/lang/FloatTest.java
>>>  > >
>>>  > >
>>>  > >
>>>  > >
>>>  >
>>>  > --
>>>  > Oliver Deakin
>>>  > Unless stated otherwise above:
>>>  > IBM United Kingdom Limited - Registered in England and Wales with number
>>  7415
>>>  > 98.
>>>  > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3
>> AU
>>>  >
>>>
>>>
>>>
> 
> 
> 

Mime
View raw message