Return-Path: 
 <dev-return-37594-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-dev-archive@www.apache.org
Received: (qmail 92357 invoked from network); 2 Jul 2009 13:40:24 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 2 Jul 2009 13:40:24 -0000
Received: (qmail 11973 invoked by uid 500); 2 Jul 2009 13:40:34 -0000
Delivered-To: apmail-harmony-dev-archive@harmony.apache.org
Received: (qmail 11906 invoked by uid 500); 2 Jul 2009 13:40:34 -0000
Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@harmony.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@harmony.apache.org>
List-Post: <mailto:dev@harmony.apache.org>
List-Id: <dev.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list dev@harmony.apache.org
Received: (qmail 11895 invoked by uid 99); 2 Jul 2009 13:40:34 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jul 2009 13:40:34 +0000
X-ASF-Spam-Status: No, hits=-2.8 required=10.0
	tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (nike.apache.org: 195.212.29.155 is neither permitted
 nor denied by domain of mark.hindess@googlemail.com)
Received: from [195.212.29.155] (HELO mtagate6.de.ibm.com) (195.212.29.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jul 2009 13:40:22 +0000
Received: from d12nrmr1507.megacenter.de.ibm.com
 (d12nrmr1507.megacenter.de.ibm.com [9.149.167.1])
	by mtagate6.de.ibm.com (8.14.3/8.13.8) with ESMTP id n62DcOrn408594
	for <dev@harmony.apache.org>; Thu, 2 Jul 2009 13:38:24 GMT
Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com
 [9.149.165.228])
	by d12nrmr1507.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
 n62DcOOL1515724
	for <dev@harmony.apache.org>; Thu, 2 Jul 2009 15:38:24 +0200
Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
 n62Db9Zt030213
	for <dev@harmony.apache.org>; Thu, 2 Jul 2009 15:37:09 +0200
Received: from anaheim.local (dhcp-9-20-183-65.hursley.ibm.com [9.20.183.65])
	by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
 n62Db9ii029656
	for <dev@harmony.apache.org>; Thu, 2 Jul 2009 15:37:09 +0200
Message-Id: <200907021337.n62Db9ii029656@d12av02.megacenter.de.ibm.com>
X-Mailer: exmh version 2.7.2 01/07/2005 (debian 1:2.7.2-16) with nmh-1.2
From: "Mark Hindess" <mark.hindess@googlemail.com>
To: "Apache Harmony Dev List" <dev@harmony.apache.org>
Subject: [classlib][build] properties in modules/*/make/hyproperties.xml
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 02 Jul 2009 14:36:58 +0100
X-Virus-Checked: Checked by ClamAV on apache.org


Does anyone actually like these properties?  I've been hacking build.xml files
and they are beginning to drive me crazy.

modules/accessibility/build.xml contains the following for creating the src 
jar:

  <jar destfile="${hy.jdk}/jre/lib/boot/${hy.accessibility.packaging.jarname}-src.jar">
    <fileset dir="${hy.accessibility.src.main.java}" />

which IMNSHO would be easier to read/maintain if it was:

  <jar destfile="${hy.jdk}/jre/lib/boot/accessibility-src.jar">
    <fileset dir="src/main/java" />

I also notice that they are used rather erratically.  For example, the
equivalent luni-src.jar creation ant code only uses one of them.

I'd like to get rid of them or, if appropriate, use more straightforward
property names such as ${jarname} since the hy.accessibility.packaging
parts are all rather obvious from the context in which they are used -
i.e. in a harmony module called accessibility building a jar file.

Sorry for the rant but I've got quite a bit build.xml cleanup to do
and assuming others agree (or don't care) I'd like to make them more
readable at the same time.

Regards,
 Mark.