Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 83374 invoked from network); 26 Jun 2009 14:29:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Jun 2009 14:29:24 -0000 Received: (qmail 74597 invoked by uid 500); 26 Jun 2009 14:29:34 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 74560 invoked by uid 500); 26 Jun 2009 14:29:34 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 74549 invoked by uid 99); 26 Jun 2009 14:29:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2009 14:29:34 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sean.xx.qiu@gmail.com designates 209.85.216.177 as permitted sender) Received: from [209.85.216.177] (HELO mail-px0-f177.google.com) (209.85.216.177) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2009 14:29:26 +0000 Received: by pxi7 with SMTP id 7so1836521pxi.20 for ; Fri, 26 Jun 2009 07:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=dHcTtn3j1IO98/rnB9zO8If3Iayynsb2gBXpqwwAWl8=; b=BOe8zOX/06pbum5trLhQZqBNuBTEs8bNeFdqC0Gqfa1j56scVPYZboOhqFxWPQ9HZ/ ag2PjGO6YoF9EpulSfZN62leDspaYn41hIV8L9uPAH/i7RO3BqISuW50pNarclHtWDF5 fg79iNRJY79VXYoillNWsaqPdA3wU0/EVSHqY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=uwm9l5Vy0NKTiqR0ylKTTrqvroZAnUq42NNY1kThhYVGEMpOEO8gCHgpVzGCAW2P0W GoiEyrUQHx1K+sTKVV94pCUirHswye1H+feCPnJLkn65XmJy2ebn0W4yF1+sUZH87Rd9 wc2So04svjMtjBpH2/4eLmZNQvUwdpm20mK7s= MIME-Version: 1.0 Received: by 10.142.225.11 with SMTP id x11mr1405778wfg.210.1246026546164; Fri, 26 Jun 2009 07:29:06 -0700 (PDT) In-Reply-To: <200906251418.n5PEI5jT004307@d12av02.megacenter.de.ibm.com> References: <20090624092855.95F6F23888C5@eris.apache.org> <200906251418.n5PEI5jT004307@d12av02.megacenter.de.ibm.com> From: Sean Qiu Date: Fri, 26 Jun 2009 22:28:46 +0800 Message-ID: <94d710af0906260728o188a3478xfc0f95a2e3c5f4ee@mail.gmail.com> Subject: Re: Test jars in the hdk (was: svn commit: r787957) To: dev@harmony.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Best Regards Sean, Xiao Xia Qiu 2009/6/25 Mark Hindess : > > Sean, > > Nice work! > > I notice that this change causes the hdk to contain > build/test/properties.xml and the identical file > build/ant/properties.xml. =A0Perhaps we can just reference the > build/ant/properties.xml version rather than make another copy. > The reason I copy another properties.xml here is to make the archived test a separated unit. It means that it could be simply copied or published as a independent compo= nent. Other wise we need copy this file and that file to make it runnable. What do you think about it? > I think we should call the 'test-jar' target as part of the top-level > "build" target since I think we really want to the hdk to be complete > after the "build" step. =A0(Much like we currently build the test support > jar.) Cool suggestion, our original task was part of ant test, which I always thought there is something weird. I have to wait until the test is finished to get the archive and yes, I can cancel it, but it is another story :-) It is much natural that test-jar be part of build, as we jar the source code in this phase. Will do it later. > > BTW, I think the targets in modules/luni/build.xml can be simplified. > For instance, the "-test-module" depends can be reduced to: > > =A0build, test-jar, run-tests > > which is a bit more readable (since "test-jar" already depends on > "compile-tests, prepare-exclude"). > I'm going to make it a little more clear within my next patch. But I think your suggestion is a better solution and makes more sense. Cool~~~ > I did LOL when I saw that this change causes the following new line > in my build output (on Aix): > > =A0[copy] Copied 14 empty directories to 2 empty directories under > =A0 =A0 =A0 =A0 =A0 =A0 deploy/build/test/luni/resources Hmm, mine on Linux, could you give more details about this? -------------------- [copy] Copying 14 files to /home/xiaoxia/checkout/hdk/working_classlib/deploy/build/test/luni [mkdir] Created dir: /home/xiaoxia/checkout/hdk/working_classlib/deploy/build/test/luni/resource= s/config [copy] Copying 1 file to /home/xiaoxia/checkout/hdk/working_classlib/deploy/build/test/luni/resource= s/config [copy] Copying 53 files to /home/xiaoxia/checkout/hdk/working_classlib/deploy/build/test/luni/resource= s [mkdir] Created dir: /home/xiaoxia/checkout/hdk/working_classlib/deploy/build/test/luni/excludes [copy] Copying 12 files to /home/xiaoxia/checkout/hdk/working_classlib/deploy/build/test/luni/excludes > > Perhaps > -Mark > > In message <20090624092855.95F6F23888C5@eris.apache.org>, qiuxx@apache.or= g > writes: >> >> Author: qiuxx >> Date: Wed Jun 24 09:28:55 2009 >> New Revision: 787957 >> >> URL: http://svn.apache.org/viewvc?rev=3D787957&view=3Drev >> Log: >> Add a top task to archive all tests into jar files independent on test t= ask, >> make testing archiving more convenient. >> >> Modified: >> =A0 =A0 harmony/enhanced/classlib/trunk/build.xml >> =A0 =A0 harmony/enhanced/classlib/trunk/make/build-test.xml >> =A0 =A0 harmony/enhanced/classlib/trunk/modules/luni/build.xml >> >> Modified: harmony/enhanced/classlib/trunk/build.xml >> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/build.= xml?r >> ev=3D787957&r1=3D787956&r2=3D787957&view=3Ddiff >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> =3D >> --- harmony/enhanced/classlib/trunk/build.xml (original) >> +++ harmony/enhanced/classlib/trunk/build.xml Wed Jun 24 09:28:55 2009 >> @@ -174,6 +174,15 @@ >> =A0 =A0 =A0 =A0 =A0> ll"/> >> =A0 =A0 =A0 >> >> + =A0 =A0> + =A0 =A0 =A0 =A0 =A0 =A0description=3D"Jar all tests"> >> + =A0 =A0 =A0 =A0 >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> +Archive testing classes ... >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> + >> + =A0 =A0 =A0 =A0> ar-modules"/> >> + =A0 =A0 >> >> =A0 =A0 =A0 >> =A0 =A0 =A0> - =A0 =A0 =A0 =A0 =A0 =A0depends=3D"clean-test-output, test-modules, pro= cess-test-output" / >> > >> + =A0 =A0 =A0 =A0 =A0 =A0depends=3D"clean-test-output, test-jar-init, te= st-modules, process >> -test-output" /> >> >> =A0 =A0 =A0> =A0 =A0 =A0 =A0 =A0 =A0 =A0depends=3D"process-empty, gen-report, check-t= est-result" /> >> @@ -56,9 +56,16 @@ >> =A0 =A0 =A0 >> >> =A0 =A0 =A0 >> + =A0 =A0 =A0 =A0 >> + =A0 =A0 >> + >> + =A0 =A0 >> =A0 =A0 =A0 =A0 =A0> /test/test.properties"/> >> =A0 =A0 =A0 =A0 =A0> st/build.xml"/> >> - =A0 =A0 =A0 =A0 >> + =A0 =A0 >> + >> + =A0 =A0 >> + =A0 =A0 =A0 =A0 >> =A0 =A0 =A0 >> >> =A0 =A0 =A0 >> >> Modified: harmony/enhanced/classlib/trunk/modules/luni/build.xml >> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/module= s/lun >> i/build.xml?rev=3D787957&r1=3D787956&r2=3D787957&view=3Ddiff >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> =3D >> --- harmony/enhanced/classlib/trunk/modules/luni/build.xml (original) >> +++ harmony/enhanced/classlib/trunk/modules/luni/build.xml Wed Jun 24 09= :28:5 >> 5 2009 >> @@ -297,7 +297,7 @@ >> =A0 =A0 =A0 =A0 =A0 >> =A0 =A0 =A0 >> >> - =A0 =A0 >> + =A0 =A0 >> =A0 =A0 =A0 =A0 =A0 >> >> =A0 =A0 =A0 =A0 =A0> pi.jar"> >> > > >