harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [vote] Declare the signed source tar of r781724 as Milestone 10
Date Mon, 08 Jun 2009 15:37:12 GMT
Mark Hindess wrote:
> In message <4A2D2561.3030009@gmail.com>, Tim Ellison writes:
>> The first thing I tried after successfully building from source, was
>> java -version.
>>
>> In M9 it prints out:
>>  c:\harmony-jdk-761593\jre\bin>java -version
>>  Apache Harmony Launcher : (c) Copyright 1991, 2008 The Apache Software
>> Foundation or its licensors, as applicable.
>>  java version "1.5.0"
>>  pre-alpha : not complete or compatible
>>  svn = r761593, (Apr  3 2009), Windows/ia32/msvc 1310, release build
>>  http://harmony.apache.org
>>
>> but in the M10 candidate it only prints:
>>  c:\apache-harmony-src-r781724\target\hdk\jdk\jre\bin>java -version
>>  java version "1.5.0"
>>  Apache Harmony (1.5.0)
>>  DRLVM (11.2.0)
>>
>> which is a regression IMHO, and so I'm inclined to vote -1 on this
>> release candidate.  Besides the all important copyright statement
>> missing, when we gather JIRAs we ask people to tell us the version they
>> are running and without the specific platform/revision it is useless.
> 
> I agree. 
> 
>> The regression seems to have come in as r763589.
> 
> Oliver changed this but he's not around so I'd like to revert this
> commit[0].  Any other committers approve this?

I agree with reverting the change.

Regards,
Tim

> [0] It is a good idea though and I'll re-commit it after M10 and think
> about what is required to fix it properly.
> 
> 
> 

Mime
View raw message