Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of sean.xx.qiu@gmail.com
 designates 209.85.221.106 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=D6JkcriqRcwBh64MrWA0MHhQq1VHi55dDRQaUznfithIKAYzuf4+qB0xhIeq9Ik5fG
         CmGHeeFTMC4d1sEZZERnzKKoSl0Vs2BGIxL52V9s2tuIHThdabJjRxbafM2v5xSjpVMW
         0Vpd8AhAqCCWxp+o9NX+Cy7Fs0Xh4UTGeGlTQ=
MIME-Version: 1.0
In-Reply-To: <3b3f27c60905272121x23952792kf22d9e4bb7c6064d@mail.gmail.com>
References: <4A1D5B2E.7060600@googlemail.com>
 <3b3f27c60905272121x23952792kf22d9e4bb7c6064d@mail.gmail.com>
From: Sean Qiu <sean.xx.qiu@gmail.com>
Date: Thu, 28 May 2009 14:02:12 +0800
Message-ID: <94d710af0905272302u2b09e1a4u4c99ce5fd3e102f9@mail.gmail.com>
Subject: Re: [M10] Testing
To: dev@harmony.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

+1

Best Regards
Sean, Xiao Xia Qiu


2009/5/28 Nathan Beyer <nbeyer@gmail.com>:
> I'd like to apply the final patch attached to
> https://issues.apache.org/jira/browse/HARMONY-6074. This seems to
> completely resolve the Maven test run issue.
>
> As for testing, I'm not seeing the hymmap issue on Windows Vista x86.
> However, the tests pass with and without this patch.
>
> -Nathan
>
> On Wed, May 27, 2009 at 10:24 AM, Oliver Deakin
> <oliver.deakin@googlemail.com> wrote:
>> Hi all,
>>
>> I've just run the classlib tests on Windows x86 on the latest code in th=
e
>> federated build and I don't see anything catastrophic there. There's 1
>> failure in the portlib tests, in hymmap, which I think is a test case
>> off-by-one error. I've attached a patch [1] which fixes the test. Apart =
from
>> that we look clean.
>>
>> Does anyone have any other test reports? Any other platforms? I'm assumi=
ng
>> we're taking r778555 as our testing base for M10.
>>
>> Regards,
>> Oliver
>>
>> [1]
>> Adding 2 to the path size for emptyFile and testFile is incorrect, as
>> pathLen already counts the rightmost DIR_SEPARATOR.
>>
>> Index: modules/portlib/src/test/native/hymmap/shared/hymmap.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- modules/portlib/src/test/native/hymmap/shared/hymmap.c =A0 =A0(revis=
ion
>> 779066)
>> +++ modules/portlib/src/test/native/hymmap/shared/hymmap.c =A0 =A0(worki=
ng copy)
>> @@ -126,8 +126,8 @@
>> =A0 =A0execName =3D strrchr(execPath, DIR_SEPARATOR) + 1; /* Find the ri=
ghtmost
>> slash character */
>> =A0 =A0pathLen =3D strlen(execPath) - strlen(execName);
>>
>> - =A0 =A0emptyFile =3D hyportLibrary->mem_allocate_memory(hyportLibrary,=
 pathLen +
>> strlen("shared") + 2 + strlen("emptyFile")); /* +2 for the extra slash a=
nd
>> null terminator */
>> - =A0 =A0testFile =3D hyportLibrary->mem_allocate_memory(hyportLibrary, =
pathLen +
>> strlen("shared") + 2 + strlen("testFile"));
>> + =A0 =A0emptyFile =3D hyportLibrary->mem_allocate_memory(hyportLibrary,=
 pathLen +
>> strlen("shared") + 1 + strlen("emptyFile")); /* +1 for the null terminat=
or
>> */
>> + =A0 =A0testFile =3D hyportLibrary->mem_allocate_memory(hyportLibrary, =
pathLen +
>> strlen("shared") + 1 + strlen("testFile"));
>>
>> =A0 =A0strncpy(emptyFile, execPath, pathLen);
>> =A0 =A0strcat(emptyFile, "shared");
>>
>> --
>> Oliver Deakin
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number
>> 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshi=
re
>> PO6 3AU
>>
>>
>