Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of oliver.deakin@googlemail.com
 designates 209.85.220.212 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=MP4a6tFfJ6DLNfInLpi5jaM838aMYtfap5HF33cz8+cWPE5Tx4YC/L0XH3oNN2x2j9
         yi9IQCmy7DWd2jiATmYbI30I5qWok/GClauyUrqdJFj6xktIphUCmpz+/ty+Vmj7wyYl
         P8Lnweg2HitCDbKxrz3iOpGhxg4b5hFZJOFJE=
Message-ID: <4A16A212.1090809@googlemail.com>
Date: Fri, 22 May 2009 14:01:06 +0100
From: Oliver Deakin <oliver.deakin@googlemail.com>
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: [classlib][misc] MemMacros.h get_unaligned and set_unaligned
 macros fail to compile on zLinux
References: <4A15789A.1050702@googlemail.com>
In-Reply-To: <4A15789A.1050702@googlemail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

The change I appended to my original mail fixes the build problem on 
zLinux 31 now. Can anyone confirm that everything works as expected on 
Linux x86_64 please? I think it is only that platform that is in danger 
of being affected by this modification.

Regards,
Oliver

Oliver Deakin wrote:
> Hi all,
>
> I have a quick question about the macros get_unaligned() and 
> set_unaligned() in MemMacros.h. When compiling on zSeries Linux 31 bit 
> systems we fall into the macros defines section for IPF machines 
> because we are on linux and __386__ is not defined. Unfortunately the 
> "(const void*) (ptr)" tries to cast a jlong (64 bit) to a 32 bit 
> pointer here and we get a "cast to pointer from integer of different 
> size" warning which is treated as an error.
>
> I'd like to fix the code to do the right thing here across all 
> platforms. Does anyone know this code well? Does the IPF section 
> (__linux__ && !__i386__) refer to Itanium machines only and not 
> x86_64? If so, would it suffice to replace the code that is there with 
> something like [1], so that only Itanium machines use the memmove() 
> based macros and all the rest (linux, windows, zos, aix etc.) use the 
> simpler cast based macros?
>
> Thanks for any help you can give!
>
> Regards,
> Oliver
>
> [1]
> #if defined(__ia64__) && defined(__linux__)
>
> #include <string.h>
> #define get_unaligned(type, ptr)                                  \
> ({                                                                \
>    type __tmp;                                                   \
>    memmove(&__tmp, (const void*) (ptr), sizeof(type));           \
>    __tmp;                                                        \
> })
>
> #define set_unaligned(type, ptr, val)                           \
> ({                                                              \
>    memmove((void*) (ptr), &val, sizeof(type));                 \
>    (void)0;                                                    \
> })
>
> #else
>
> #define get_unaligned(type, ptr) ( *((type *)((uintptr_t)(ptr))) )
> #define set_unaligned(type, ptr, val) ( (void) (*((type 
> *)((uintptr_t)(ptr))) = val) )
>
> #endif
>

-- 
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU