harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Qiu <sean.xx....@gmail.com>
Subject Re: [M10] Testing
Date Thu, 28 May 2009 06:02:12 GMT
+1

Best Regards
Sean, Xiao Xia Qiu




2009/5/28 Nathan Beyer <nbeyer@gmail.com>:
> I'd like to apply the final patch attached to
> https://issues.apache.org/jira/browse/HARMONY-6074. This seems to
> completely resolve the Maven test run issue.
>
> As for testing, I'm not seeing the hymmap issue on Windows Vista x86.
> However, the tests pass with and without this patch.
>
> -Nathan
>
> On Wed, May 27, 2009 at 10:24 AM, Oliver Deakin
> <oliver.deakin@googlemail.com> wrote:
>> Hi all,
>>
>> I've just run the classlib tests on Windows x86 on the latest code in the
>> federated build and I don't see anything catastrophic there. There's 1
>> failure in the portlib tests, in hymmap, which I think is a test case
>> off-by-one error. I've attached a patch [1] which fixes the test. Apart from
>> that we look clean.
>>
>> Does anyone have any other test reports? Any other platforms? I'm assuming
>> we're taking r778555 as our testing base for M10.
>>
>> Regards,
>> Oliver
>>
>> [1]
>> Adding 2 to the path size for emptyFile and testFile is incorrect, as
>> pathLen already counts the rightmost DIR_SEPARATOR.
>>
>> Index: modules/portlib/src/test/native/hymmap/shared/hymmap.c
>> ===================================================================
>> --- modules/portlib/src/test/native/hymmap/shared/hymmap.c    (revision
>> 779066)
>> +++ modules/portlib/src/test/native/hymmap/shared/hymmap.c    (working copy)
>> @@ -126,8 +126,8 @@
>>    execName = strrchr(execPath, DIR_SEPARATOR) + 1; /* Find the rightmost
>> slash character */
>>    pathLen = strlen(execPath) - strlen(execName);
>>
>> -    emptyFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen +
>> strlen("shared") + 2 + strlen("emptyFile")); /* +2 for the extra slash and
>> null terminator */
>> -    testFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen +
>> strlen("shared") + 2 + strlen("testFile"));
>> +    emptyFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen +
>> strlen("shared") + 1 + strlen("emptyFile")); /* +1 for the null terminator
>> */
>> +    testFile = hyportLibrary->mem_allocate_memory(hyportLibrary, pathLen +
>> strlen("shared") + 1 + strlen("testFile"));
>>
>>    strncpy(emptyFile, execPath, pathLen);
>>    strcat(emptyFile, "shared");
>>
>> --
>> Oliver Deakin
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number
>> 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
>> PO6 3AU
>>
>>
>

Mime
View raw message