Looks like the patch has 2 committers supporting - I'm also +1 to fixing
the test crashes and if the patch for HARMONY-6132 does this without
affecting any of the other tests, then Im also +1 to the patch. Please
go ahead and commit it as soon as possible so we can begin final testing.
Regards,
Oliver
Alexey Varlamov wrote:
> 2009/5/28, Mark Hindess <mark.hindess@googlemail.com>:
> [skipped]
>
>> I also had two test crashes:
>>
>> org.apache.harmony.luni.tests.java.net.SocketTest
>> org.apache.harmony.xnet.provider.jsse.SSLSocketImplTest
>>
>> which were both fixed by Ilya's patch in HARMONY-6132.
>>
>> I think it would be good to apply the patch from HARMONY-6132 before M10.
>> Does anyone else support/oppose this?
>>
>
> The fix looks reasonable and the issue is important enough to fix it in M10.
> --
> Alexey
>
>
>> Regards,
>> Mark.
>>
>>
>>
>>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
|