harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: Float/Double comparison performance
Date Fri, 08 May 2009 14:05:21 GMT
Ian Rogers wrote:
> 2009/5/8 Tim Ellison <t.p.ellison@gmail.com>:
>> I think it would be better to separate out the > and == tests, i.e.:
>> -        if (float1 >= float2 && (0.0f != float1 || 0.0f != float2)) {
>> +        if (float1 > float2) {
>>             return false;
>>         }
>> +        if (float1 == float2 && 0.0f != float1) {
>> +            return false;
>> +        }
>>
>> WDYT?
> 
> I agree :-)

Ok, take a look at r772994.

I expect MRP to *fly* after all this attention ;-)

Tim

Mime
View raw message