Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of t.p.ellison@gmail.com
 designates 209.85.221.121 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=PB6cN985ohcOmQFqwmEG7vEDwumRr6jRjd5MqWSiTn9yEwVFqgiRRvMd2JEFQZ/nyw
         y1RMi0Cl0Y8PMzkh8+BWJo1Gx6/kg+IfIGG8UD1IXp0KQzADFJ2z5xEK8RRI451V2kzb
         RNZNWxK5HCrN7JdX7FZ61bBaEDzzntH5bze2Q=
Message-ID: <49EC3531.5060201@gmail.com>
Date: Mon, 20 Apr 2009 09:41:21 +0100
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: [test] Platform spcific tests (was: Re: svn commit: r765837 -
 /harmony/enhanced/classlib/trunk/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/SocketTest.java)
References: <20090417023601.A75FC23889DE@eris.apache.org>
 <49E85955.6060605@gmail.com> <49E85D0A.4080700@gmail.com>
 <49EA38A0.8010305@gmail.com> <49EBE8BC.9050608@gmail.com>
In-Reply-To: <49EBE8BC.9050608@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Regis wrote:
> Tim Ellison wrote:
>> Regis wrote:
>>> RI has the different behaviors on Linux and Windows in this test case,
>>> and Harmony has the exactly the same behaviors, so I think our
>>> implementation is OK.
>>>
>>> And there are some other similar cases in SocketTest, which failed on
>>> Linux but passed on Windows, I think it's why it is in
>>> exclude.linux.x86.drl. If we fixed them, SocketTest could be moved from
>>> exclude list.
>>
>> It wasn't the fact that there is a difference that I object to here, but
>> the way you have achieved it does not fit in the Harmony architecture.
>>
>> These types of differences are pushed into the native code.  I believe
>> that this should be done here too.
> 
> Our tests are all written in java, I think it's better to keep it. How
> about move these platform depended tests to platform directory, like
> UnixSocketTest or WinSocketTest?

D'oh, sorry, I had missed that they are tests!

The platform specific tests are sorted into directories under
  src/test/api		(Java API-based tests)
or
  src/test/impl		(Harmony impl types tests)


The test you modified is in
  src/test/api/common

but if it is platform specific, the relevant parts of the test should be
in one of
  src/test/api/windows
or
  src/test/api/unix


Does that make sense?

Regards,
Tim