From dev-return-37075-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Wed Apr 29 14:24:46 2009 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 29721 invoked from network); 29 Apr 2009 14:24:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 29 Apr 2009 14:24:46 -0000 Received: (qmail 48253 invoked by uid 500); 29 Apr 2009 14:24:46 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 48182 invoked by uid 500); 29 Apr 2009 14:24:46 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 48171 invoked by uid 99); 29 Apr 2009 14:24:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2009 14:24:46 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of alexei.fedotov@gmail.com designates 209.85.218.211 as permitted sender) Received: from [209.85.218.211] (HELO mail-bw0-f211.google.com) (209.85.218.211) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2009 14:24:34 +0000 Received: by bwz7 with SMTP id 7so1214383bwz.36 for ; Wed, 29 Apr 2009 07:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=aYoQny0NVKFDpDFwftKaIhpW4TwyBWaFUWvVa9528vQ=; b=DkERLSf+wiMTQkfj+OIT0cMcmVV3LEkhM41VgOCwm5XXjtW5U7H0R/keUkozRq8avw wHFdQ0HI/ieo+Y8v9LdsEsyW7Xp4PhkumT0PLifED5OlgTS6ISpbzrVLMxVxbjvpApDd JeQmtEH8khEfUfzldtTzFvKvEskkFuKhn3DGM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=E0eSThPRbjVmmis/dvfoAL17zh/K7lEycWPn3/VwDozx0ujVEPm4QCE8Nrr7PENieK fXgLiYPzqI43tSAd4zntJ/l9beH+EgxkvVDIatkxDOqFPXJkbG6IJ6czJqMoOgbJky+Y 0B4629ug3EVppxuyRhw+2OlYVkX7h55t+ekcs= MIME-Version: 1.0 Received: by 10.103.218.9 with SMTP id v9mr262092muq.78.1241015054007; Wed, 29 Apr 2009 07:24:14 -0700 (PDT) In-Reply-To: <49F84D1D.5020304@googlemail.com> References: <49F84D1D.5020304@googlemail.com> Date: Wed, 29 Apr 2009 18:24:13 +0400 Message-ID: Subject: Re: [jdktools][jdwp] Updated Java 6 JDWP contribution From: Alexei Fedotov To: dev@harmony.apache.org Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Oliver, This is very interesting update. Nice job! One who looks into native.zip may suggest that the code is new, but in fact it looks like more an incremental change. I have noticed the following and posting it here, so people knew what's happening: * 10 source files were added, * new Java 6 features were added as operations, * C++ exceptions were replaced with function return codes and function-like syntax, * 82 @author tags naming Aleksander Budniy, Anatoly Bondarenko, Viacheslav Rybalov, Anton Karnachuk, Pavel Vyssotski, Vitaly Provodin were removed (haven't we agreed keeping them as is? well, at least they can be found in this message) * usage of C strings were added, * logging macros were replaced from C++-like syntax to C syntax, * strange comments, e.g. /* Fix for 143846 - make sure we pass EBCDIC strings to zOS system functions */ appeared with no additional context on what is 143846 * the newly added code contains commented code, e.g. // printf("Looking for equivalent of java line %d in stratum %s\n", // lineNumber, stratum); or /* ProcPtr jdwp::GetProcAddress(LoadedLibraryHandler libHandler, const char* procName) do we have a good reason to commit a commented code? * there are several /* FIXME - Workaround for shutdown crashes */ comments in the new code, * several doxygen comments start with an incorrect verb form (see http://java.sun.com/j2se/javadoc/writingdoccomments/#format for a correct one), the comments like /** A constructor. */ are not very helpful. On Wed, Apr 29, 2009 at 4:50 PM, Oliver Deakin wrote: > Hi all, > > A little while ago, IBM created a mirror of the Java 6 jdktools branch so > that we could start bringing Harmony JDWP into the IBM Java releases. We > began working in that mirror because it was convenient for our internal > builds, with a plan to reflect all changes we made back into Harmony as w= e > went. Unfortunately, as deadlines drew in and releases came and went thos= e > plans did not come into fruition - until now :) > > I'd like to announce the contribution of an enhanced Java 6 level JDWP ag= ent > and socket transport layer. It has been attached to HARMONY-6187 [1] for > everyone to try out - please take a look. It has the following enhancemen= ts: > - A large number of bug fixes. > - Ported to a wide variety of platforms - Linux x86/x86_64, Linux PPC 32/= 64, > zLinux 31/64, Windows x86/x86_64, AIX PPC 32/64 and zOS 31/64. > - As part of the porting process, all non-portable C++ usage has been > removed and rewritten, particularly use of C++ standard libraries. > - JSR 45 support implemented. The new JDWP agent allows debugging of > non-Java stratum code running on the VM, for example JSPs. > - Significant performance improvements. > > All authors already have ACQs recorded. There may be some more work to be > done to get the new JDWP functioning 100% with Harmony, but I'd rather do > that work out in the open once it is committed. Please let me know if the= re > are any objections/comments to this contribution! I'll give it a few days > and then start a vote. > > Regards, > Oliver > > [1] https://issues.apache.org/jira/browse/HARMONY-6187 > > > -- > Oliver Deakin > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshir= e > PO6 3AU > > --=20 With best regards / =D3 =CE=C1=C9=CC=D5=DE=DB=C9=CD=C9 =D0=CF=D6=C5=CC=C1= =CE=C9=D1=CD=C9, Alexei Fedotov / =E1=CC=C5=CB=D3=C5=CA =E6=C5=C4=CF=D4=CF=D7, http://www.telecom-express.ru/ http://people.apache.org/~aaf/ http://harmony.apache.org/ http://code.google.com/p/openmeetings/