harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Yu <junjie0...@gmail.com>
Subject Re: about upgrade icu4j 3.8 to icu4j 4.0
Date Wed, 15 Apr 2009 05:27:23 GMT
2009/4/15 Deven You <devyoudw@gmail.com>

> 2009/4/14 Regis <xu.regis@gmail.com>
>
> > Deven You wrote:
> >
> >> I remember I did it a long time ago, there were 2 - 3 issues about
> icu4.0.
> >> And I will run the whole test this week.
> >>
> >> 2009/2/24 Sian January <sianjanuary@googlemail.com>
> >>
> >>  Sounds like a good idea.  Deven - did you run the Harmony tests at all
> >>> with the new ICU?
> >>>
> >>> Thanks,
> >>>
> >>> Sian
> >>>
> >>>
> >>> 2009/2/24 Mark Hindess <mark.hindess@googlemail.com>:
> >>>
> >>>> In message <
> efe92bae0902200123p77037a46s965966c262c50ce8@mail.gmail.com
> >>>> ,
> >>>> Deven You writes:
> >>>>
> >>>>> Hi,
> >>>>> I have tried to upgrade icu4j3.8 to icu4j4.0 for  classlib trunk
on
> my
> >>>>> machine, below is the instructions for this upgrade:
> >>>>> 1. download  icu4j-4_0.jar and icu4j-charsets-4_0.jar from ICU
> official
> >>>>> website http://icu-project.org/download/4.0.html
> >>>>> 2. create icu4j_4.0 folder in trunk/depends/jars, copy icu4j-4_0.jar
> >>>>> and
> >>>>> icu4j-charsets-4_0.jar into icu4j_4.0 folder
> >>>>> 3. create icu4j_4.0 folder in trunk/depends/manifests, copy META-INF
> >>>>>
> >>>> foledr
> >>>
> >>>> from icu4j_3.8 and use version 4.0 replace 3.8 in the MANIFEST.MF
>  file.
> >>>>> 4. apply configuration patch[1] for icu4.0 to change some
> configuration
> >>>>> settings.
> >>>>> 5.  apply nio Charset patch[2] to avoid circular dependency error,
if
> >>>>> no
> >>>>> this patch,  nio_char unit test will report many circular dependency
> >>>>> error[3]
> >>>>>
> >>>>> I think maybe now we can upgrade icu4j 3.8 to icu4j 4.0.
> >>>>> any issues welcom to discuss!
> >>>>>
> >>>>> [1]
> >>>>>
> >>>>>
> >>>
> https://issues.apache.org/jira/secure/attachment/12400589/config_icu40.diff
> >>>
> >>>> [2]
> >>>>>
> >>>>
> https://issues.apache.org/jira/secure/attachment/12400590/Charset.diff
> >>>
> >>>> [3]
> >>>>>
> >>>>>
> >>>
> https://issues.apache.org/jira/secure/attachment/12400591/nio_char_errors.txt
> >>>
> >>>> Seems like a good idea.  I'll try to find a moment to test this.
> >>>>
> >>>> What are the benefits we get from this upgrade?  Performance?
> >>>>  Footprint?
> >>>>
> >>>> In case it helps anyone else, the JIRA with these attachments is:
> >>>>
> >>>>  https://issues.apache.org/jira/browse/HARMONY-6096
> >>>>
> >>>> (I don't think there is an easy way to get from attachment links back
> to
> >>>>
> >>> the
> >>>
> >>>> jira link?)
> >>>>
> >>>> Regards,
> >>>> -Mark.
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>> --
> >>> Unless stated otherwise above:
> >>> IBM United Kingdom Limited - Registered in England and Wales with
> number
> >>> 741598.
> >>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> >>> 3AU
> >>>
> >>>
> >>
> > Since M9 already released, I'd like to apply the patch for this upgrade.
> I
> > tried  your patches on HARMONY-6096 and HARMONY-6119, followed
> instructions,
> > and then ran the all unit tests, still got some test failures not seen in
> > M9:
> > org.apache.harmony.luni.tests.java.util.CurrencyTest:
> >    test_getInstanceLjava_util_Locale
> >    test_getSymbol
> >    test_getSymbolLjava_util_Locale
>
>
>      I will put patch for above 3 failures soon.
>
> >
> > org.apache.harmony.luni.tests.java.util.LocaleTest
> >    test_getISO3Language
> > org.apache.harmony.luni.tests.java.util.TimeZoneTest
> >    test_getDisplayNameZILjava_util_Locale
>
>
>    I haven't investigated above 2 failures.


I've checked these 2 failures and found they were both caused by obsolete
testcase as ICU is upgraded.
Will raise JIRA for them.


>
>
> >
> > org.apache.harmony.nio_char.tests.java.nio.charset.CharsetTest
> >    test_isRegistered
> > have investigated, it seems a bit complicated, will fix it later.
> > Do you have any in hands patches to resolve them? I'd like to try them
> > before applying.
> >
> > --
> > Best Regards,
> > Regis.
> >
>



-- 
Best Regards,
Jim, Jun Jie Yu

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message