harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nathan Beyer <ndbe...@apache.org>
Subject Re: svn commit: r764270 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/URLClassLoader.java
Date Mon, 20 Apr 2009 23:28:21 GMT
Kevin,
Can you comment on this question?

On Mon, Apr 20, 2009 at 2:42 AM, Tim Ellison <t.p.ellison@gmail.com> wrote:
> Nathan Beyer wrote:
>> On Sat, Apr 18, 2009 at 3:32 PM, Tim Ellison <t.p.ellison@gmail.com> wrote:
>>> I'm interested too.
>>
>> I hope that doesn't mean you think my code is getting bad. :)
>
> :-)  not at all.  I am simply interested to know if there is still a
> problem to solve here.  I was expecting your question to get a response.
>
> Regards,
> Tim
>
>
>>> Nathan Beyer wrote:
>>>> I just wanted to validate that my change didn't cause the problem, it
>>>> just revealed it, correct?
>>>>
>>>> -Nathan
>>>>
>>>> On Mon, Apr 13, 2009 at 12:00 PM, Nathan Beyer <nbeyer@gmail.com> wrote:
>>>>> I will look at it but someone else can pick it up if needed.
>>>>>
>>>>> Sent from my iPhone
>>>>>
>>>>> On Apr 12, 2009, at 9:02 PM, Kevin Zhou <zhoukevin83@gmail.com>
wrote:
>>>>>
>>>>>> Hi Nathan,
>>>>>> I found that you applied a patch to java.net.URLClassLoader.
>>>>>> This defect have been reported previously on HARMONY-6136 [1].
>>>>>> The current patch given by you triggers two test errors for
>>>>>> "test_findClassLjava_lang_String" and "test_findResource methods"
of
>>>>>> URLClassLoaderTest, which throws a java.lang.StackOverflowError.
>>>>>> If the META-INF/INDEX.LIST file of a jar contains a link to the jar,
it
>>>>>> will
>>>>>> invoke a endless recursion.
>>>>>> I have attached a new patch on [1]. Would you please help to try
it?
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/browse/HARMONY-6136
>>>>>> [2] Stack Trace:
>>>>>> java.lang.StackOverflowError
>>>>>>   at java.net.URL.fixURL(URL.java:464)
>>>>>>   at java.net.URL.set(URL.java:509)
>>>>>>   at java.net.URL.set(URL.java:924)
>>>>>>   at java.net.URLStreamHandler.setURL(URLStreamHandler.java:298)
>>>>>>   at java.net.URLStreamHandler.parseURL(URLStreamHandler.java:234)
>>>>>>   at
>>>>>>
>>>>>> org.apache.harmony.luni.internal.net.www.protocol.file.Handler.parseURL(Handler.java:111)
>>>>>>   at java.net.URL.<init>(URL.java:338)
>>>>>>   at java.net.URL.<init>(URL.java:155)
>>>>>>   at
>>>>>>
>>>>>> org.apache.harmony.luni.internal.net.www.protocol.jar.Handler.parseURL(Handler.java:86)
>>>>>>   at java.net.URL.<init>(URL.java:338)
>>>>>>   at java.net.URL.<init>(URL.java:155)
>>>>>>   at
>>>>>> java.net.URLClassLoader$IndexFile.readIndexFile(URLClassLoader.java:137)
>>>>>>   at java.net.URLClassLoader$URLJarHandler.<init>(URLClassLoader.java:316)
>>>>>>   at java.net.URLClassLoader.createURLJarHandler(URLClassLoader.java:1043)
>>>>>>   at java.net.URLClassLoader.access$5(URLClassLoader.java:1022)
>>>>>>   at
>>>>>>
>>>>>> java.net.URLClassLoader$URLJarHandler.getSubHandler(URLClassLoader.java:480)
>>>>>>   at
>>>>>>
>>>>>> java.net.URLClassLoader$URLJarHandler.findResources(URLClassLoader.java:345)
>>>>>>   at
>>>>>>
>>>>>> java.net.URLClassLoader$URLJarHandler.findResources(URLClassLoader.java:347)
>>>>>>   at
>>>>>>
>>>>>> java.net.URLClassLoader$URLJarHandler.findResources(URLClassLoader.java:347)
>>>>>> ......
>>
>

Mime
View raw message