harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: [classlib][icu] Upgrade to 4.0
Date Tue, 28 Apr 2009 07:32:26 GMT

In message <3b3f27c60904271742s6c28e414rb0c5e2327b62be28@mail.gmail.com>,
Nathan Beyer writes:
>
> I committed this change. the ICU library is now a fetched download.
> This may require a clean and fetch before building correctly.

Excellent.

I thought the jars used in the original contribution contained some (not
yet released) fixes.  This certainly doesn't apply any more.

Regards,
 Mark.


> -Nathant
> 
> On Mon, Apr 27, 2009 at 10:55 AM, Tim Ellison <t.p.ellison@gmail.com> wrote=
> :
> > Should be as simple as this:
> >
> > Index: make/depends.properties
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- make/depends.properties =C2=A0 =C2=A0 (revision 768745)
> > +++ make/depends.properties =C2=A0 =C2=A0 (working copy)
> > @@ -145,3 +145,15 @@
> > =C2=A0asm.jar=3D${asm.dir}/asm-3.1.jar
> > =C2=A0asm.url=3Dhttp://download.forge.objectweb.org/asm/asm-3.1.jar
> > =C2=A0asm.md5=3D4fbe0fd975ecc71480846ce272b483b0
> > +
> > +icu4j.ver=3Dicu4j_4.0
> > +icu4j.dir=3D${depends.jars}/${icu4j.ver}
> > +icu4j.jar=3D${icu4j.dir}/icu4j-4_0.jar
> > +icu4j.url=3Dhttp://download.icu-project.org/files/icu4j/4.0/icu4j-4_0.ja=
> r
> > +icu4j.md5=3D08397653119558593204474fd5a9a7e3
> > +
> > +icu4j-charsets.ver=3Dicu4j_4.0
> > +icu4j-charsets.dir=3D${depends.jars}/${icu4j.ver}
> > +icu4j-charsets.jar=3D${icu4j.dir}/icu4j-charsets-4_0.jar
> > +icu4j-charsets.url=3Dhttp://download.icu-project.org/files/icu4j/4.0/icu=
> 4j-charsets-4_0.jar
> > +icu4j-charsets.md5=3D5dd1d6aaffa6762e09541b3bb412d8ee
> > Index: make/depends.xml
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- make/depends.xml =C2=A0 =C2=A0(revision 768745)
> > +++ make/depends.xml =C2=A0 =C2=A0(working copy)
> > @@ -57,6 +57,8 @@
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 <check-one-file src=3D"${dejavu-fonts.url}"
> > dest=3D"${dejavu-fonts.zip}" />
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 <check-one-file src=3D"${derby.url}" dest=3D"=
> ${derby.jar}" />
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 <check-one-file src=3D"${asm.url}" dest=3D"${=
> asm.jar}" />
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0<check-one-file src=3D"${icu4j.url}" dest=3D=
> "${icu4j.jar}" />
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0<check-one-file src=3D"${icu4j-charsets.url}=
> "
> > dest=3D"${icu4j-charsets.jar}" />
> > =C2=A0 =C2=A0 </target>
> >
> > =C2=A0 =C2=A0 <target name=3D"-check-win" if=3D"is.windows"
> > depends=3D"-really-check-win" />
> > @@ -225,6 +227,15 @@
> > =C2=A0 =C2=A0 <mkdir dir=3D"${asm.dir}" />
> > =C2=A0 =C2=A0 <download-one-file src=3D"${asm.url}" dest=3D"${asm.jar}"
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
> =A0 =C2=A0 =C2=A0 =C2=A0md5=3D"${asm.md5}" />
> > +
> > + =C2=A0 =C2=A0<mkdir dir=3D"${icu4j.dir}" />
> > + =C2=A0 =C2=A0<download-one-file src=3D"${icu4j.url}"
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
> =C2=A0 dest=3D"${icu4j.jar}"
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
> =C2=A0 md5=3D"${icu4j.md5}" />
> > + =C2=A0 =C2=A0<download-one-file src=3D"${icu4j-charsets.url}"
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
> =C2=A0 dest=3D"${icu4j-charsets.jar}"
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
> =C2=A0 md5=3D"${icu4j-charsets.md5}" />
> > +
> > =C2=A0 =C2=A0 </target>
> >
> > =C2=A0 =C2=A0 <target name=3D"-download-win" if=3D"is.windows">
> >
> >
> > Tim Ellison wrote:
> >> Nathan Beyer wrote:
> >>> Why do we commit icu to svn? The jars are available via http, correct?
> >>
> >> Yes they are - I don't know why they are stored. =C2=A0We could (should)
> >> download them.
> >>
> >> Regards,
> >> Tim
> >>
> >>> On Apr 27, 2009, at 3:41 AM, Regis <xu.regis@gmail.com> wrote:
> >>>
> >>>> Tim Ellison wrote:
> >>>>> In the context of HARMONY-879, Nathan wrote:
> >>>>>> Can you verify that you're not still using ICU 3.8? I know
> >>>>>> I had to clean it out in a few places.
> >>>>> What do you mean? that simply updating my working copy doesn't do
the
> >>>>> right thing? =C2=A0I seemed to be getting 4.0 behaviour in the tests.
> >>>>> ...and yet I do still see that I have a copy of ICU4J 3.8 in my
> >>>>> workspace since it has not been removed from the repository yet
[1]
> >>>>> Can we delete all the 3.8 stuff now?
> >>>>> [1]
> >>>>> https://svn.apache.org/repos/asf/harmony/enhanced/classlib/trunk/depe=
> nds/jars
> >>>>>
> >>>>> Regards,
> >>>>> Tim
> >>>> Oops, the icu4j_3.8 folder is empty, I'll remove it soon. The all jars
> >>>> of icu 3.8 have been removed, so I think it shouldn't affect any tests=
> .
> >>>>
> >>>> --
> >>>> Best Regards,
> >>>> Regis.
> >>
> >
> 



Mime
View raw message