Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (nike.apache.org: domain of t.p.ellison@gmail.com
 designates 209.85.219.161 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=ETh9WSN+zo0456srBZRcIpTiMuW6yPsNl0C8BIyRhsYY1yUNDIqoVmMV49G8kx+Jnl
         jehLuK+PGvVOc6UfXTK4SUhL9ahZmNtXbEBlga69FXs6kZRV8H4wtLz+4m08Ko7cp60+
         dOsdVODqri+Ltqtrc1ztFH/FONaxGR22zdvdE=
Message-ID: <49C11628.8000804@gmail.com>
Date: Wed, 18 Mar 2009 15:41:28 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: [M9] Testing - outstanding issues
References: <fc2fc95c0903130359m521bbf6s99ef80ee94bb60a6@mail.gmail.com>
	 <fc2fc95c0903160331r36f13667y34956f60c273a92b@mail.gmail.com>
	 <49BF3858.5080503@gmail.com>
	 <fc2fc95c0903170808r21bafc34xb5d554eb22f8cd9a@mail.gmail.com>
	 <49BFD516.6030602@gmail.com>
 <E1Ljfry-0006Xn-JA@pih-relay05.plus.net>	 <c30d70960903171334j24d9e3a0nff821cae1bab75c9@mail.gmail.com>
	 <49C09DF0.1050000@gmail.com>
	 <fc2fc95c0903180245k5a7307b2v99bf5169ea1c7172@mail.gmail.com>
	 <49C0EB0B.9060805@gmail.com>
 <fc2fc95c0903180820t23e30a08jf97a63a925577d@mail.gmail.com>
In-Reply-To: <fc2fc95c0903180820t23e30a08jf97a63a925577d@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Thanks for the review...

Sian January wrote:
> The patch looks fine for this case, but if I was being picky I would
> wonder if we also need to throw an IOException for an infinite stream
> that does contain '\n' characters as well as for one that doesn't?

The RI runs forever on a stream of '\n's and we run up to an
OutOfMemoryException.  It's such a contrived case that I really don't
think we need to hang forever too to match the behavior.

> Also is '\n' ok to use across all platforms or should it be something
> like System.getProperty(line.separator)?

The manifest format spec says:
  newline :  CR LF | LF | CR (not followed by LF)

so I'll change the containsLine test to be
  if (buffer[i] == 0x0A || buffer[i] == 0x0D) {

Sounds reasonable?

Thanks again,
Tim


> 2009/3/18 Tim Ellison <t.p.ellison@gmail.com>:
>> Sian January wrote:
>>> 2. org.apache.harmony.archive.tests.java.util.jar.ManifestTest fails
>>> on Windows XP [Tim is working on this]
>> I have a proposed patch ready for this problem, see
>>
>> https://issues.apache.org/jira/browse/HARMONY-6121
>>
>> it's not a one-liner, so I'd appreciate another set of eyeballs on it
>> before nominating it as a commit into M9.
>>
>> Thanks,
>> Tim
>>
>>
> 
> 
>