Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of wuyuehao@gmail.com designates
 209.85.200.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=Plx0MEI9otPBhnMuPFFpi0BJ7USbIj2rbbl21o8keGyy276/k9ECzNIwTpqDafv9G7
         9oStO0o1tG2UfnN3mYcRmyCVygvccaGuYNypULr/hwljkBcyf7eM138p+LTGUfJWfx7m
         pyqh9AxDh311F6dHydq4Cr5OCGxSH4ddN8KgM=
MIME-Version: 1.0
In-Reply-To: <5948b71e0902162346s654a3a03xe457dfcc24ffb042@mail.gmail.com>
References: <5948b71e0902162346s654a3a03xe457dfcc24ffb042@mail.gmail.com>
Date: Tue, 17 Feb 2009 16:03:09 +0800
Message-ID: <211709bc0902170003mf4d69cdyf6439489518e9461@mail.gmail.com>
Subject: Re: [classlib][luni]httpclient code in HttpConnection.java
From: Tony Wu <wuyuehao@gmail.com>
To: dev@harmony.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

I think we should update to a lastest stable version, 480424 is tooooo
old, probably 2 years ago?

On Tue, Feb 17, 2009 at 3:46 PM, Charles Lee <littlee1032@gmail.com> wrote:
> Hi guys,
>
> We are using some code from the jakarta common's HttpConnection.java in our
> org.apache.harmony.luni.internal.net.www.protocol.http.HttpConnection.java.
> From the comment above the code, we are using a quite old revision r480424.
>
> In the method isStale(), we have used inputStream.mark(1). But from the
> spec, we have "The general contract of mark is that, if the method
> markSupported returns true, the stream somehow remembers all the bytes read
> after the call to mark and stands ready to supply those same bytes again if
> and whenever the method reset is called. However, the stream is not required
> to remember any data at all if more than readlimit bytes are read from the
> stream before reset is called. " So I guess we should test markSupported()
> first.
>
> 1. Should we update the code to the latest revision?
> 2. Should we modify the code ourselves and get rid of the jakarta commons?
>
> Any idea?
>
> --
> Yours sincerely,
> Charles Lee
> China Software Development Lab, IBM
>


-- 
Tony Wu
China Software Development Lab, IBM