harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chunrong lai <chunrong...@gmail.com>
Subject Re: M9 (Feature Freeze starts tomorrow)
Date Fri, 27 Feb 2009 09:25:19 GMT
 Thanks. I'd like to double check this with wenlong and xiaofeng.
 I am +1 to not include the feature to M9. Thus I am OK for a feature freeze
now. :-)

On Fri, Feb 27, 2009 at 5:17 PM, Alexei Fedotov <alexei.fedotov@gmail.com>wrote:

> Chunrong,
>
> I've made a simple check instead of reading the whole patch. I've
> checked the only comment which stuck into my memory, namely adding
> assert for a sanity check of strstr( (*it).second->bytes, pkgName )
> result. I believe disregarded comments are to be supplied with note
> why they are disregarded - otherwise, it makes code reviews useless.
>
> BTW, this comment took me three clarification letters, so it is hardly
> to be forgotten. :-)
>
> Thanks.
>
>
> On Fri, Feb 27, 2009 at 11:57 AM, Alexei Fedotov
> <alexei.fedotov@gmail.com> wrote:
> > I'm sorry I'm a bit out of time to carefully read the new patch. As
> > far as I remember the last patch I've read lacked serious defects.
> > Wenlong, let me just ask if all my comments are addressed.
> >
> > On Wed, Feb 25, 2009 at 11:36 PM, Mark Hindess
> > <mark.hindess@googlemail.com> wrote:
> >>
> >> In message
> >> <f9761b910902250908t275baa3eh8cbc75a7e5c19725@mail.gmail.com>, chunrong
> >> lai writes:
> >>>
> >>>   Thanks.
> >>>   I am just not sure if we should check in the on-demand jar loading,
> >>> HARMONY-6039, as a new feature of M9.
> >>
> >> It looks like no one has commented on the latest version of the patch
> >> for this JIRA.  It is not clear if this means the patch is now perfect
> >> or that no one has looked at it since it was updated.
> >>
> >> I'd be happier about committing it if you were more confident and/or if
> >> Pavel/Alexei gave their opinions otherwise I'd suggest waiting for M10.
> >>
> >> Regards,
> >>  Mark.
> >>
> >>
> >>
> >
> >
> >
> > --
> > С уважением,
> > Алексей Федотов,
> > http://people.apache.org/~aaf/
> >
>
>
>
> --
> С уважением,
> Алексей Федотов,
> http://people.apache.org/~aaf/
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message