harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Regis <xu.re...@gmail.com>
Subject Re: [classlib][luni]httpclient code in HttpConnection.java
Date Wed, 18 Feb 2009 03:07:06 GMT
Charles Lee wrote:
> On Tue, Feb 17, 2009 at 5:43 PM, Regis <xu.regis@gmail.com> wrote:
> 
>> Charles Lee wrote:
>>
>>> Hi guys,
>>>
>>> We are using some code from the jakarta common's HttpConnection.java in
>>> our
>>>
>>> org.apache.harmony.luni.internal.net.www.protocol.http.HttpConnection.java.
>>>
>>>> From the comment above the code, we are using a quite old revision
>>>> r480424.
>>>>
>>> In the method isStale(), we have used inputStream.mark(1). But from the
>>> spec, we have "The general contract of mark is that, if the method
>>> markSupported returns true, the stream somehow remembers all the bytes
>>> read
>>> after the call to mark and stands ready to supply those same bytes again
>>> if
>>> and whenever the method reset is called. However, the stream is not
>>> required
>>> to remember any data at all if more than readlimit bytes are read from the
>>> stream before reset is called. " So I guess we should test markSupported()
>>> first.
>>>
>>> 1. Should we update the code to the latest revision?
>>>
>> does the latest code work well with harmony?
> 
> I have done some investigation. It seems that this is the newest version....
> 
> 
>>
>>  2. Should we modify the code ourselves and get rid of the jakarta commons?
>> If it's easy to fix it by ourselves, I incline to get rid of the jakarka
>> commons.
> 
> If the inputStream does not support mark, what policy should we use? Simple
> return true?
> 
How about wrapping a simple implemented stream which support mark operation?

>>
>>
>>> Any idea?
>>>
>>>
>> --
>> Best Regards,
>> Regis.
>>
> 
> 
> 


-- 
Best Regards,
Regis.

Mime
View raw message