harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xiaoming gu <xiaoming...@gmail.com>
Subject Re: discussion for H5022
Date Fri, 06 Feb 2009 08:27:52 GMT
In latest version, I couldn't see the code mentioned in this JIRA. And the
only operations about heap base in HIR2LIR pass are for zeroForComparison,
ldnull, simpleLdInd, simpleStInd and ldRef. Thanks.

Xiaoming

On Fri, Feb 6, 2009 at 4:05 PM, Egor Pasko <egor.pasko@gmail.com> wrote:

> On the 0x550 day of Apache Harmony Xiao-Feng Li wrote:
> > If that's the case, we can close it now.
> >
> > On Fri, Feb 6, 2009 at 3:00 PM, xiaoming gu <xiaoming.gu@gmail.com>
> wrote:
> >> I read the code about heap base address in Ia32InstCodeSelector.cpp and
> >> checked the operands created by those parts of code with a simple test
> case
> >> on a Windows64 machine. The code itself and the practical results both
> show
> >> all related operands created in HIR2LIR pass are in 64-bit size. Thanks.
>
> As I can see from HARMONY-5022 the problem is that the encoder
> truncates these operands. Did you verify that 64 bit imm for
> SUB/ADD/CMP were not truncated? How about to put an assert for such
> (silent) truncation into encoder?
>
> --
> Egor Pasko
>
>


-- 
China Runtime Technologies Lab,
SSG/SSD/MRTC, Intel

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message