Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (nike.apache.org: domain of t.p.ellison@gmail.com
 designates 66.249.92.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=OWrp+Aa0pJi33p9ZuyQRWZ0zSrDueki1Smb0JwrFOd6m9tYSn6HtQpWC7yuYq4wt2T
         Tmj5XKHVnjp3LcXLl/dCkzbzaKpT7uI/Og8C+syXn3hm+54JJcULZ9/aiDX1Sm9B9TOE
         3O0yfj5LftPiOX6FFRxSniAyPTBy/FobR6IkU=
Message-ID: <493E6CEA.3070208@gmail.com>
Date: Tue, 09 Dec 2008 13:04:42 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 2.0.0.18 (Windows/20081105)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: [classlib] [luni] Should Improve File System Exception Messages
References: <297100561.1228445444854.JavaMail.jira@brutus>
	 <70c713190812041903i5ca0920agee58291279d007fd@mail.gmail.com>
	 <4938AE77.80706@gmail.com>
 <c8963150812042200n6d87c269oa54062b840de474b@mail.gmail.com>
 <4938D9B3.3080307@gmail.com> <49395A0E.5090009@gmail.com>
 <493DE6FF.5000108@gmail.com>
In-Reply-To: <493DE6FF.5000108@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Regis wrote:
> I found readImpl and writeImpl in OSFileSystem.c use
> 
> netLookupErrorString(env, HYPORT_ERROR_FILE_LOCKED)
> 
> to get error messages, which are hard coded in nethelp.c, my questions are:
> 
> 1. why does file read/write need to get error messages from nethelp.c?
> We already have hyfile_error_message() can do that.

HYPORT_ERROR_* messges are platform independent so you can pass them
around in common code.

You should not use hyfile_error_message() since it is not thread safe -
i.e. you might get back an error/success for a different thread's file
operation.  Its use is deprecated.

> 2. error messages are hard coded in netLookupErrorString, is that expected?

That is used to map from the HYPORT_ERROR_* messages to a display
string, so yes it is expected, but maybe not what we want to use here.

In general, portlib functions that make OS calls set a per-thread error
code (using hyerror_set_last_error()), and the users of the portlib
retrieve it using hyerror_last_error_number() and the corresponding
display string using hyerror_last_error_message().

Take a look at the portlib functions in hyerror.c

Regards,
Tim