Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of nbeyer@gmail.com designates
 209.85.217.10 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=roSWwzUynnB+J9YRRg/vPTGPagIRujwpEUVp9b7deJkg8eXziYJk+BRx3dJs5qHdGb
         kr3ia9ORfwgIv8kDAmKkNRnIGePUvVyp1Psuj0fZCfNu4NbsxpREVHpQDS7KtPsj8J++
         5oTU1rvfiNZ2tpwWge/ewN92B+OkVgOg2iLqM=
Message-ID: <3b3f27c60812302131i503df6aax398c72322dec4710@mail.gmail.com>
Date: Tue, 30 Dec 2008 23:31:40 -0600
From: "Nathan Beyer" <nbeyer@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib][prefs] default provider of prefs
In-Reply-To: <5948b71e0812301718n7371c522td910303120d7f718@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4959F70B.7080504@gmail.com>
	 <3b3f27c60812300737o2940a2dkdd219bd8b04eb9d9@mail.gmail.com>
	 <5948b71e0812301718n7371c522td910303120d7f718@mail.gmail.com>

That wasn't what was asked, nor was that what I commented about,
unless I'm missing something. What does putting the platform default
into native code have to do with the order of service provider load?

Any reason the algorithm can't be implemented all in Java with the
following steps.
1. Check System Property, if set, construct; if not set or failure, do step 2
2. Check SPI files, if available, load, construct, etc; if not set or
all fail, do step 3
3. Determine OS, load OS-specific provider

I haven't looked at the code yet - is the code setting the system
property to communicate the classname?

-Nathan

On Tue, Dec 30, 2008 at 7:18 PM, Charles Lee <littlee1032@gmail.com> wrote:
> Hi Nathan,Prefs has its priority list to load a factory builder. The first
> priority is System Property, the second is service info in any jar file, and
> the last the is platform default.
> If we have set the platform default value to the System Property in the luni
> before the prefs's constructor, that will make platform default be the first
> priority. And user can not specify the factory builder by service info in
> the jar file.
>
> On Tue, Dec 30, 2008 at 11:37 PM, Nathan Beyer <ndbeyer@apache.org> wrote:
>
>> I doubt there is any significant reason for it other than the default
>> is based on the OS and the native might have been an easy decision
>> point.
>>
>> Moving it to Java code is probably fine - the code just needs to use a
>> default based on the OS.
>>
>> -Nathan
>>
>> On Tue, Dec 30, 2008 at 4:25 AM, Regis <xu.regis@gmail.com> wrote:
>> > Hi,
>> >
>> > The provider of prefs is controlled by the property
>> > "java.util.prefs.PreferencesFactory" in Harmony, and we also have
>> different
>> > default values for it on Linux and Windows, but the default values are
>> set
>> > in luni module at modules/luni/src/main/native/luni/shared/luniglob.c,
>> > are there any special concerns that we must do it in luni native code? Or
>> is
>> > it possible set it in prefs module with java code, like this:
>> >
>> >         if (factoryClassName == null) {
>> >             if (isWindows) {
>> >                 factoryClassName =
>> > "java.util.prefs.RegistryPreferencesFactoryImpl";
>> >             } else {
>> >                 factoryClassName =
>> > "java.util.prefs.FilePreferencesFactoryImpl";
>> >             }
>> >         }
>> >
>> > I think there must be a way to get current platform at runtime in java.
>> >
>> > --
>> > Best Regards,
>> > Regis.
>> >
>>
>
>
>
> --
> Yours sincerely,
> Charles Lee
> China Software Development Lab, IBM
>