harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Zhou" <zhoukevi...@gmail.com>
Subject Re: [jira] Commented: (HARMONY-6043) [classlib] [security] UnresolvedPermission.equals(Object) doesn't works well
Date Sat, 13 Dec 2008 00:43:30 GMT
Alexey wrote,
> One must make defensive copy when setting array properties - plain
assigment of array reference is unsafe.
Yes, this assigment of arry reference is unsafe. But no spec says that the
array of certificates in a UnresovledPermission need to be thread-safe.
If we add a lock to guarantee its safe, how about the other methods which
access to targetCerts array. Do we need to make them safe too?

>Looking on the test source, I'd rather consider this as non-bug difference.

I think this is different behaviors between RI and HARMONY of determining
certificate equality?
The previous implementation of HARMONY uses PolicyUtils.matchSubSet method
which behaves differently from RI.

I think we'd better follow RI's behaviors on this.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message