harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <ndbe...@apache.org>
Subject Re: Using PriviAction instead of PrivilegedAction
Date Tue, 23 Dec 2008 23:46:16 GMT
I meant that it's a logical mess - it does a number of different
things and it's not what I would call elegant code.

If a more central and common utility is desired, then I'd suggest
creating one from scratch to replace PriviAction.

-Nathan

On Tue, Dec 23, 2008 at 3:51 AM, Alexei Fedotov
<alexei.fedotov@gmail.com> wrote:
> Well, I would say it was pretty well formatted.
>
> The thing I don't like about this class is a mess of different
> security applications which cannot be deducted from naming. The class
> would be easier to understand if split into four appropriately named
> actions. This would also help renaming arg1, arg2 fields into
> something readable.
>
>
>
> On Tue, Dec 23, 2008 at 12:42 PM, Kevin Zhou <zhoukevin83@gmail.com> wrote:
>> Is this PriviAction really an ugly class?
>>
>
>
>
> --
> С уважением,
> Алексей Федотов,
> ЗАО «Телеком Экспресс»
>
Mime
View raw message