harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <ndbe...@apache.org>
Subject Re: Using PriviAction instead of PrivilegedAction
Date Tue, 23 Dec 2008 05:27:31 GMT
On Mon, Dec 22, 2008 at 11:15 PM, Kevin Zhou <zhoukevin83@gmail.com> wrote:
> Nathan, thanks for your comments.
>
> Nathan wrote,
>> This would create a dependency on every module to an implementation
> package in LUNI.
> Yes, that would be.
>
>> I'd suggest each module create one helper class, as needed, and reuse that
> internally.
> Adding an internally-used helper class can improve modularity. But I doubt
> that it may bring redundant codes.
> For example, both LUNI and Security needs to access the system properties.
> In fact, PriviAction implements PrivilegedAction and only provides services
> to get system properties, security properties and so.

I understand, but eliminating redundant code isn't an absolute value
-- it's not always a good thing. Reuse must be balanced with the
requirements of modularity and the needs of isolation.

-Nathan

>
>> As I recall, PriviAction is quite an ugly class - it's rather a mess.
> What about improving this helper class instead of adding an internal helper
> classes in each module?
>

Mime
View raw message