harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Wu" <wuyue...@gmail.com>
Subject Re: [classlib][luni] the same OSMemory.h in windows and unix
Date Mon, 01 Dec 2008 07:36:45 GMT
I think so. since we already have the OSMemoryWin32 and
OSMemoryLinux32.c for the different implementation.

On Mon, Dec 1, 2008 at 3:11 PM, Regis <xu.regis@gmail.com> wrote:
> Hi,
> I just found OSMemory.h has almost the same content in windows and unix, the
> only differences are order of function definitions and comments. So I think
> if they should be merged and moved to shared directory?
> And I go through OSMemory.c quickly, found the most implementation are also
> similar, looks like:
> windows:
> hymem_free_memory ((void *) address);
> unix:
> hymem_free_memory ((void *) ((IDATA) address));
> I'm not clear why we need one more cast here, or is it possible to merge
> this two implementations to one? If so, I'm volunteer to do this :)

Tony Wu
China Software Development Lab, IBM

View raw message