Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 62423 invoked from network); 20 Nov 2008 02:10:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Nov 2008 02:10:26 -0000 Received: (qmail 71809 invoked by uid 500); 20 Nov 2008 02:10:34 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 71774 invoked by uid 500); 20 Nov 2008 02:10:34 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 71763 invoked by uid 99); 20 Nov 2008 02:10:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Nov 2008 18:10:34 -0800 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of zhoukevin83@gmail.com designates 72.14.204.226 as permitted sender) Received: from [72.14.204.226] (HELO qb-out-0506.google.com) (72.14.204.226) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Nov 2008 02:09:12 +0000 Received: by qb-out-0506.google.com with SMTP id e12so227242qba.0 for ; Wed, 19 Nov 2008 18:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type:references; bh=xfDGyfdVbIbCqq+5oFElTDBy85NGcPVuep9Bw6fPalk=; b=gKaXuvbbG2Jhd3sjCr99OXEEJDVecYj8GQtPqm38S8o02aYr0jYZJLNsI9+Ahu8Y/q eAdgIwLRNuWUjCbl/WGWnepo3c06yfJwsNSXKiORnj4zItNPAy1lo7DLR4yA39vBUvjJ 6Nlr0vZ0zsfo48vu3gM+fV2Tj+mroG/88jwZY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:references; b=FX/jKSr/PojbyE7QRmU5i3MV3fimT2Gsd3v/DTAwylcyLIEkSDb+101qX5a5i4/8dQ zlUWnZhTt9LgswR3XyCeYfnss7vBIj74aYMzIkYnww1G2X7B5PkwcyWnjTtV1S1Fv2Bx 6TJHh/q/RVQ8Yxl9eT2s+pOe4wZbhYjGkigBA= Received: by 10.142.147.15 with SMTP id u15mr847325wfd.317.1227146996904; Wed, 19 Nov 2008 18:09:56 -0800 (PST) Received: by 10.143.37.4 with HTTP; Wed, 19 Nov 2008 18:09:56 -0800 (PST) Message-ID: <70c713190811191809s47b1748fha9da49c0b2d1a51@mail.gmail.com> Date: Thu, 20 Nov 2008 10:09:56 +0800 From: "Kevin Zhou" To: dev@harmony.apache.org Subject: Re: About In-Reply-To: <4924C521.70007@gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_149070_19889226.1227146996892" References: <4924C521.70007@gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_149070_19889226.1227146996892 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Please ignore this mail. I send a new one with subject: "[classlib][luni] Redundant and repeated external properties loading using ResourceBundle may degrade performance." On Thu, Nov 20, 2008 at 10:02 AM, Kevin Zhou wrote: > Hi, > I read some code in LUNI module of Harmony. > (org.apache.harmony.luni.util.Msg/MsgHelp and java.util.ResourceBundle) > I found that Harmony uses ResourceBundle to load messages from external > properties file. > e.g. Once it requires a message "K0046", it will always use ResourceBundle > to go through the org.apache.harmony.luni.util.ExternalMessages.properties > file to search it. > I think such redundant and repeated I/O operations may degrade our > performance. > > Why not use a hashtable to store all the external messages? It only > requires several I/O operations initially! > > ------=_Part_149070_19889226.1227146996892--