harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunrong lai" <chunrong...@gmail.com>
Subject Re: [vote] Declare r711744 as M8
Date Wed, 12 Nov 2008 10:59:47 GMT
hi, Aleksey:
   Thanks a lot for the notice. I am less pessimistic than you because:
  (1) Only adding null pointer checking (throw exception if NullObject)
looks not such a big issue.
  (2) We had run monitor_enter_stub with nullpointer checking code for some
time. So I'd like to think that they have been well tested.

On Wed, Nov 12, 2008 at 6:28 PM, Aleksey Shipilev <
aleksey.shipilev@gmail.com> wrote:

> On Wed, Nov 12, 2008 at 1:12 PM, Tim Ellison <t.p.ellison@gmail.com>
> wrote:
> > Aleksey Shipilev wrote:
> >> BTW, would Chunrong have to re-run the tests from scratch after fixing
> >> HARMONY-6013?
> > Not if the change is local enough that Buqi (or whoever writes it) is
> > confident that targeted testing is going to be enough for this one
> > patch.  If it is a design/architectural change then yes we would restart
> > the testing.
> The change in monitor_enter, even the safest one, touches every
> application that runs. Just because it's touching threading and
> synchronization. So I'm very pessimistic that ordinary reasoning on
> "change locality" is enough here. Like we can't miss this NPE bug in
> M8, we can't miss the occasional regression while fixing this bug :)
> Thanks,
> Aleksey.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message