harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Fedotov" <alexei.fedo...@gmail.com>
Subject Re: Enable the MACRO _DEBUG_CHECK_NULL_
Date Wed, 12 Nov 2008 09:24:46 GMT
I wonder if may get Mikhail advice on this.

On Wed, Nov 12, 2008 at 12:08 PM, chunrong lai <chunronglai@gmail.com> wrote:
> hi, colleagues:
>     I am asking for the support of other committers to enable the MACRO
> _DEBUG_CHECK_NULL_ (in include/jit_runtime_support.h), because of the rule
> of M8 code frozen period.
>     I need the MACRO to enable the test case as in HARMONY-6013, which
> throws uncaught NullPointerException. The exception comes with the stub of
> vm_rt_monitor_enter.  We had not met the reported exception because we
> originally have two null checkings with that. The first one is just before
> the stub. The second is inside the stub.
>     Now we find that the first null checking before the stub will be
> removed after some aggressive optimizations. Also a commit r659128 moved the
> null checking (and exception throwing) codes inside the stub into the
> regions guarded by the disabled macro  MACRO _DEBUG_CHECK_NULL_ . As the
> result drlvm just fails in running such test cases.
>     Buqi is checking JIT codes to prepare another patch. But I am not sure
> if we should wait and include the patch in M8. Or we can just try that after
> code unfrozen.

С уважением,
Алексей Федотов,
Телеком Экспресс
View raw message