harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [classlib][luni] Tidying up OSNetworkSystem
Date Fri, 28 Nov 2008 13:01:40 GMT
I have cleaned up socket read and write code in the OSNetworkSystem natives.

Things are working ok for java.net code, but the NIO SocketChannel stuff
breaks if I switch it from the current hokey receiveStream
implementation - so I've left it in there as deprecated for a while
while the NIO code is fixed up.

It looks like the SocketChannel impl needs some review.  Some simple
examples are not working, and there are strange assumptions (e.g.
timeout values for blocking and non-blocking?! sockets).

I feel like I'm pulling a thread here that could unravel all sorts ;-)


Jimmy,Jing Lv wrote:
> Hi,
>     That's cool Tim, I am interested and I'd like to a volunteer to
> review/refactor the codes if needed  :)
>     Please tell me anything I can help.
> 2008/11/22 Tim Ellison <t.p.ellison@gmail.com>:
>> I've started to tidy up the Java APIs in OSNetworkSystem that, for some
>> inexplicable reason, seems to have two method calls for each API method
>> (the public instance method dispatches to a package static method ?!)
>> and other junk.
>> There is a motley set of APIs accumulated in there too, which I'll go
>> back and rationalize once I'm through the grunt work.
>> I'll be committing it in steps since there is a good chance for typos to
>>  creep in.  Everything should stay working at all times, so let me know
>> if things break.
>> Regards,
>> Tim
>> tellison@apache.org wrote:
>>> Author: tellison
>>> Date: Fri Nov 21 08:42:48 2008
>>> New Revision: 719634
>>> URL: http://svn.apache.org/viewvc?rev=719634&view=rev
>>> Log:
>>> Start to tidy up the network interface.
>>> First part of removing redundant methods and adopting sensible names.
>>> Modified:
>>>     harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/OSNetworkSystem.java
>>>     harmony/enhanced/classlib/trunk/modules/luni/src/main/native/luni/shared/OSNetworkSystem.c
>>>     harmony/enhanced/classlib/trunk/modules/luni/src/main/native/luni/shared/OSNetworkSystem.h
>>>     harmony/enhanced/classlib/trunk/modules/luni/src/main/native/luni/unix/OSNetworkSystemLinux.c
>>>     harmony/enhanced/classlib/trunk/modules/luni/src/main/native/luni/unix/exports.txt
>>>     harmony/enhanced/classlib/trunk/modules/luni/src/main/native/luni/windows/OSNetworkSystemWin32.c

View raw message