harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [jira] Commented: (HARMONY-6008) [classlib] Fix japi found differences between harmony and spec
Date Wed, 05 Nov 2008 02:34:27 GMT
messed up the address first time ;-/

-------- Original Message --------
Subject: Re: [jira] Commented: (HARMONY-6008) [classlib] Fix japi found
differences between harmony and spec
Date: Wed, 05 Nov 2008 02:05:02 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
To: Nathan Beyer (JIRA) <jira@apache.org>

Nathan Beyer (JIRA) wrote:
> What's up with the changes like this?
> 
> -    static final String TOGGLE_EXPAND = "toggle expand"; //$NON-NLS-1$
> -    static final String INCREMENT = "increment"; //$NON-NLS-1$
> -    static final String DECREMENT = "decrement"; //$NON-NLS-1$
> +    static final String TOGGLE_EXPAND = new String("toggle expand"); //$NON-NLS-1$
> +    static final String INCREMENT = new String("increment"); //$NON-NLS-1$
> +    static final String DECREMENT = new String("decrement"); //$NON-NLS-1$
> 
> What does that do?

Fixes problems reported as :

Bad

 * field javax.accessibility.AccessibleAction.DECREMENT: constant
[decrement] in harmony15, but not constant in jdk15
 * field javax.accessibility.AccessibleAction.INCREMENT: constant
[increment] in harmony15, but not constant in jdk15

That is, the actual value is computed at runtime rather than compile
time.  Not sure that it would make any difference in practice, but it
may form part of the signature test which is why I suppose japi cares
about it.

Regards,
Tim



Mime
View raw message