Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of chunronglai@gmail.com
 designates 64.233.166.183 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:references;
        b=ff9+n4f9gDahESkdJPi/LpJalJGUHMA0X3tPlftDP9DcHDrP0nQVGuKYHXAwPdCDQt
         aYBlGHA7gbDJ/3KPIFKgzTzF1jWSAr72YEjXlN6PaL3viPWxIVfYr00V5G0hmwaJ5zI3
         5aRn0rvqCwq/Etqd23828Z/XFx7INFLTJ3T+g=
Message-ID: <f9761b910809040806k38574cbdsc270fd9d307e4901@mail.gmail.com>
Date: Thu, 4 Sep 2008 23:06:02 +0800
From: "chunrong lai" <chunronglai@gmail.com>
To: dev@harmony.apache.org
Subject: Re: svn commit: r691476 - in
 /harmony/enhanced/classlib/trunk/modules/concurrent: build.xml
 make/hyproperties.xml
In-Reply-To: <20080903024427.DC41F238899E@eris.apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_26879_3857051.1220540762978"
References: <20080903024427.DC41F238899E@eris.apache.org>

------=_Part_26879_3857051.1220540762978
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

hi, Nathan:
    I see the commit breaks some classlib test, include ReentrantLockTest,
AbstractQueuedSynchronizerTest, ExecutorsTest and ScheduledExecutorTest, as
reported in the integrity testing. Do we need a check?
   One can reproduce the error in the directory of working_classlib: ant
-Dtest.jre.home=...\drlvm\...\jdk\jre -Dtest.case=ReentrantLockTest test.
    Thanks.


On 9/3/08, ndbeyer@apache.org <ndbeyer@apache.org> wrote:
>
> Author: ndbeyer
> Date: Tue Sep  2 19:44:27 2008
> New Revision: 691476
>
> URL: http://svn.apache.org/viewvc?rev=691476&view=rev
> Log:
> fix test targets to execute tests in 'standard' folder
>
> Modified:
>    harmony/enhanced/classlib/trunk/modules/concurrent/build.xml
>    harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml
>
> Modified: harmony/enhanced/classlib/trunk/modules/concurrent/build.xml
> URL:
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/concurrent/build.xml?rev=691476&r1=691475&r2=691476&view=diff
>
> ==============================================================================
> --- harmony/enhanced/classlib/trunk/modules/concurrent/build.xml (original)
> +++ harmony/enhanced/classlib/trunk/modules/concurrent/build.xml Tue Sep  2
> 19:44:27 2008
> @@ -61,7 +61,7 @@
>     </target>
>
>     <!-- internal target for local and global test run sequence -->
> -    <target name="-test-module" depends="prepare-exclude" />
> +    <target name="-test-module" depends="build, compile-tests,
> prepare-exclude, run-tests" />
>
>     <target name="clean">
>         <delete
> file="${hy.jdk}/jre/lib/boot/${hy.concurrent.packaging.jarname}.jar" />
> @@ -77,8 +77,8 @@
>
>         <mkdir dir="${hy.build}" />
>
> -        <javac sourcepath=""
> -               destdir="${hy.build}"
> +        <javac destdir="${hy.build}"
> +               sourcepath=""
>                compiler="${hy.javac.compiler}"
>                memoryMaximumSize="${hy.javac.maxmem}"
>                source="${hy.javac.source}"
> @@ -125,8 +125,7 @@
>
>         <mkdir dir="${hy.concurrent.bin.test}" />
>
> -        <javac srcdir="${hy.concurrent.src.test.java}"
> -               destdir="${hy.concurrent.bin.test}"
> +        <javac destdir="${hy.concurrent.bin.test}"
>                sourcepath=""
>                compiler="${hy.javac.compiler}"
>                memoryMaximumSize="${hy.javac.maxmem}"
> @@ -190,6 +189,13 @@
>                     <include name="**/*Test.java" unless="test.case" />
>                     <excludesfile name="${concurrent.exclude.file}"
> unless="test.case" />
>                 </fileset>
> +                <fileset dir="${hy.concurrent.src.test.standard}">
> +                    <!-- if ${test.case}     -->
> +                    <include name="${converted.tc}" if="test.case" />
> +                    <!-- unless ${test.case} -->
> +                    <include name="**/*Test.java" unless="test.case" />
> +                    <excludesfile name="${concurrent.exclude.file}"
> unless="test.case" />
> +                </fileset>
>             </batchtest>
>         </junit>
>         <antcall target="touch-failures-file" />
>
> Modified:
> harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml
> URL:
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml?rev=691476&r1=691475&r2=691476&view=diff
>
> ==============================================================================
> ---
> harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml
> (original)
> +++
> harmony/enhanced/classlib/trunk/modules/concurrent/make/hyproperties.xml Tue
> Sep  2 19:44:27 2008
> @@ -21,10 +21,12 @@
>       <src>
>          <main>
>             <java location="src/main/java" />
> +            <standard location="standard/src/main/java" />
>             <resources location="src/main/resources" />
>          </main>
>          <test>
>             <java location="src/test/java" />
> +            <standard location="standard/src/test/java" />
>             <resources location="src/test/resources" />
>          </test>
>       </src>
>
>
>

------=_Part_26879_3857051.1220540762978--