harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [classlib][build][freebsd] Fix Classlib build for FreeBSD 6.3 x86
Date Thu, 04 Sep 2008 11:21:00 GMT
Mark Hindess wrote:
> In message <48BFAB84.2090000@gmail.com>, Tim Ellison writes:
>> Mark Hindess wrote:
>>> +#if defined(FREEBSD)
>>> +#define HY_VEC_T char
>>> +#else
>>> +#define HY_VEC_T unsigned char
>>> +#endif
>>> +         HY_VEC_T* vec = NULL;
>> Am I misreading this?  It used to be char* on non-FREEBSD systems, and
>> you needed to change it to be unsigned char* ?
> Not exactly.  But your confusion is understandable.  I should have explained
> this change.  I'm fixing two things:
>    a) vec was a char* but the only place it was used as char* was in the
>       cast from the void* returned by hymem_allocate_memory.  It was then
>       forced to unsigned char*.  Logically it made more sense to just
>       change vec to unsigned char* and fix the cast.
>    b) The type of the third parameter to mincore on freebsd needs to be char*.
> That should make more sense now?

Yes, thanks.  I had not figured out the 'double step'.

> (Of course, if I'd committed it I would
> have explained that in the commit message.)

Of course ;-)


View raw message