Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of junjie0122@gmail.com
 designates 72.14.220.157 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:references;
        b=wrYQQ3GBlZ3ta5+oUwLjNEyPx1v4kuVpFC84wjlb4yr13s8M6970xPzekQyUUhmVKR
         DW0VZQtSEG+wuYE/w8Y1tt4Idn1+cGUQXpC+jVqbwwK+M6UnTmJbQ9OyPPKEgrKj1hh6
         DH9yNBLzngrKCyZ3vD2f4TUOO006fELtRtoog=
Message-ID: <c8963150808270304o4fbe1dd0m9099feec0324b6e4@mail.gmail.com>
Date: Wed, 27 Aug 2008 18:04:08 +0800
From: "Jim Yu" <junjie0122@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib][util] java.util.Date.toString output is inconsistent
 with RI
In-Reply-To: <c3755b3a0808270220habf603fgab2c36a86fb7c391@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_3227_27477628.1219831448938"
References: <c8963150808270209g27f4990eu7da3a759c591b50b@mail.gmail.com>
	 <c3755b3a0808270220habf603fgab2c36a86fb7c391@mail.gmail.com>

------=_Part_3227_27477628.1219831448938
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Good idea. I've revised my patch and attached it to the JIRA again. Thanks,
Alexey.

2008/8/27 Alexey Petrenko <alexey.a.petrenko@gmail.com>

> I would suggest to change toDayOfWeek and toMonth methods to simple
> static arrays. We do not need these calls and switches in this case.
>
> Thanks in advance.
>
> SY, Alexey
>
> 2008/8/27 Jim Yu <junjie0122@gmail.com>:
> > Hi all,
> >
> > I took a look at [1] and found that we can remove the delegation to
> > SimpleDateFormat since we only use the en-us locale here.
> > I think we can easily implement this method instead of delegating to
> > SimpleDateFormat. Then, this defect can be easily resolved.
> > Moreover, invoking SimpleDateFormat will lead to low performance of this
> > API. For a simple testcase as below [2], the original
> > result is 119667 millisecs while the result after applying my patch is
> only
> > 1140 millisecs. I've attached my patch to this JIRA.
> > Is there anyone to verify the patch? Thanks.
> >
> > [1] https://issues.apache.org/jira/browse/HARMONY-5468
> > [2]
> > import java.util.Date;
> >
> > public class DateToStringTest {
> >
> >    public static void main(String[] args) {
> >        long start = System.currentTimeMillis();
> >        Date date = new Date();
> >        long count = 100000;
> >        System.out.println(date.toString());
> >        while(--count != 0) {
> >              date.toString();
> >        }
> >        System.out.println(System.currentTimeMillis() - start);
> >    }
> > }
> > --
> > Best Regards,
> > Jim, Jun Jie Yu
> >
> > China Software Development Lab, IBM
> >
>


-- 
Best Regards,
Jim, Jun Jie Yu

China Software Development Lab, IBM

------=_Part_3227_27477628.1219831448938--