Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of senakafdo@gmail.com
 designates 209.85.142.187 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:references;
        b=NY8ABffR6+ZA2wfllUaUKQ/Qx3XJ2U+B1sR98Rfnpno2m3owYXylEHEWWxNd+0vpnv
         vSjC6qBRZYi0P+SCHLdanSFln0ApLSdem5+MIxRbzX3DMXdSdrhVU7/kS/bkHeFYa5oV
         DClWniaYzLf+Zt+CU7R6vs3JrcPDElFeUOoJ8=
Message-ID: <8812c4670807172150l10181ci186610bb51ff893c@mail.gmail.com>
Date: Fri, 18 Jul 2008 10:20:15 +0530
From: "Senaka Fernando" <senakafdo@gmail.com>
To: dev@harmony.apache.org
Subject: Re: clarification on Localizing GC
In-Reply-To: <9623c9a50807171835m6c9cd9c2hdc81280c626b945d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_5023_30416479.1216356615571"
References: <8812c4670807171452ted7b05fn5c7de1d8ddd0e59@mail.gmail.com>
	 <9623c9a50807171835m6c9cd9c2hdc81280c626b945d@mail.gmail.com>

------=_Part_5023_30416479.1216356615571
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Xiao-Feng,

On Fri, Jul 18, 2008 at 7:05 AM, Xiao-Feng Li <xiaofeng.li@gmail.com> wrote:

> On Fri, Jul 18, 2008 at 5:52 AM, Senaka Fernando <senakafdo@gmail.com>
> wrote:
> > Hi all,
> >
> > I have few questions regarding localizing the GC.
> >
> > 1. Isn't this buggy (working_vm/vm/gc_gen/src/common/large_pages.cpp:129)
> >
> >     if (proc_huge_pages_total * proc_huge_page_size >= required_size) {
> >      WARN(("GC large_page: Not enough free large pages, some of reserved
> > space is already busy."));
> >     } else {
> >      WARN(("GC large_page: Not enough free large pages, some of reserved
> > space is already busy."));
> >     }
>
>

>
> What's the bug you are mentioning?


In here, both inside the if and inside the else we have the same code. Why
do we need a if-else here? or is there some mistake made in the warning
message?

>
>
> > 2. What's WARN2, and DIE2? where are they defined?
>
> Please try to find their definitions yourself.


I couldn't find them defined in any header. And, they lie in code portions
that won't be compiled, or commented source.

>
>
> Thanks,
> xiaofeng


Regards,
Senaka

------=_Part_5023_30416479.1216356615571--