From dev-return-34683-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Sun Jul 27 16:16:32 2008 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 34289 invoked from network); 27 Jul 2008 16:16:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Jul 2008 16:16:32 -0000 Received: (qmail 61768 invoked by uid 500); 27 Jul 2008 16:16:29 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 61730 invoked by uid 500); 27 Jul 2008 16:16:29 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 61719 invoked by uid 99); 27 Jul 2008 16:16:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jul 2008 09:16:29 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of nbeyer@gmail.com designates 209.85.128.184 as permitted sender) Received: from [209.85.128.184] (HELO fk-out-0910.google.com) (209.85.128.184) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jul 2008 16:15:35 +0000 Received: by fk-out-0910.google.com with SMTP id 26so4453935fkx.4 for ; Sun, 27 Jul 2008 09:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:in-reply-to:mime-version:content-type:references :x-google-sender-auth; bh=OpabFLQqLkHMeHUlihmc0XLrTioibW3c9qDsCqKfoVQ=; b=m1sXssRHDTN6hRIdWvjUqQSapj7cXzKCH+diDQOFTa43y63YvYJe9t2mT336Bijctn 1pn8tWSTNLgsD8OWCnmlLRwVIAe/MMsSy7D9HcSOpPO1D3lWJUM6cK2hSXhtduQgugHY uQGHHcEroaVYrtKgFjQ+IoD244Z7G+2xTSdu4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version :content-type:references:x-google-sender-auth; b=CmmkE7GmaSPUjCCv1pL79wOH6nD8kHP/pGgCfXAl4erVO4j+nuSwlkr5kKKaGazMGu fzGluvIMpcM1ASLl9lv+sGSrOBDYuTskcm1Ry4aodMRo3ixf4e/m4yHJXeSE5ncTt1eD m+Eck8wxNTO/QlX1nxfOZSYv1To5SN8+xWPuA= Received: by 10.125.102.19 with SMTP id e19mr227762mkm.61.1217175342907; Sun, 27 Jul 2008 09:15:42 -0700 (PDT) Received: by 10.125.38.19 with HTTP; Sun, 27 Jul 2008 09:15:42 -0700 (PDT) Message-ID: <3b3f27c60807270915o6570517dwf26b49f721c20422@mail.gmail.com> Date: Sun, 27 Jul 2008 11:15:42 -0500 From: "Nathan Beyer" Sender: nbeyer@gmail.com To: dev@harmony.apache.org Subject: Re: Fixing HARMONY-1187 is a matter of decision In-Reply-To: <8812c4670807270332p5d008584l79afdf4bbd4aeb52@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_6960_3571452.1217175342901" References: <8812c4670807270332p5d008584l79afdf4bbd4aeb52@mail.gmail.com> X-Google-Sender-Auth: 9c8602bff2066589 X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_6960_3571452.1217175342901 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline Just so I understand, you're saying that an instance of URLConnection is assumed to be a JarURLConnection and in some cases it's not. I don't know that there's much to decide. If the API says URLConnection and there's no documentation/comment/assertion to indicate that is MUST be a JarURLConnection, then the code needs to be patched to support this condition. It's probably just some quickly written code that no one came back to. Do you have a suggested patch for fixing the class? -Nathan On Sun, Jul 27, 2008 at 5:32 AM, Senaka Fernando wrote: > Hi all, > > HARMONY-1187, [1] can be solved if we choose not to assume that the > URLConnection is not an extension of java.net.JarURLConnection. However, we > need to decide on this. The file in question is [2]. > > [1] https://issues.apache.org/jira/browse/HARMONY-1187 > [2] > working_classlib/modules/luni/src/main/java/java/net/URLClassLoader.java > > > Regards, > Senaka > ------=_Part_6960_3571452.1217175342901--