Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 14162 invoked from network); 4 Jun 2008 01:47:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Jun 2008 01:47:38 -0000 Received: (qmail 82682 invoked by uid 500); 4 Jun 2008 01:47:40 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 82644 invoked by uid 500); 4 Jun 2008 01:47:40 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 82632 invoked by uid 99); 4 Jun 2008 01:47:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 18:47:40 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sean.xx.qiu@gmail.com designates 209.85.142.188 as permitted sender) Received: from [209.85.142.188] (HELO ti-out-0910.google.com) (209.85.142.188) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2008 01:46:51 +0000 Received: by ti-out-0910.google.com with SMTP id y6so839906tia.18 for ; Tue, 03 Jun 2008 18:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=WJYnGSYRLYcDRIVIlGwTswF9Kfl2iGevIXM0AzhQ5sQ=; b=s9aAhRQFjwnF0Od/43YXVBSC7LK9oNSHlQj0U0+G9XsJf7Tt0lGAH+X3kuwCYg/0Kh2WpJXKeKfqukLbRZueWgJkGtwsvb/xl7OHnTle7H+mjfd3SqpwsvbvcdWwQ6dRA5DDDx9eHAzJQ+37HEj21a7p+QSX4wqQK/WBsn2LCas= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DqOJmd5QwiZvZFKTDXatDxQxs7kVwr4xxhZ2pztY7rE5Ujy7h+R/OrRj3LP9cxFBVnesetdSQmfO5o99FnjtrKvLBtfqi9GhlutEmJA0DS7pddLmrX6yoO60Yu+2nS/SCELFNfp3lXOGlU1Le76yYyTuhekXGA306jr28+VMNyk= Received: by 10.110.40.8 with SMTP id n8mr1861222tin.7.1212544027016; Tue, 03 Jun 2008 18:47:07 -0700 (PDT) Received: by 10.110.17.14 with HTTP; Tue, 3 Jun 2008 18:47:06 -0700 (PDT) Message-ID: <94d710af0806031847h55422b43tc4f616557898ef18@mail.gmail.com> Date: Wed, 4 Jun 2008 09:47:06 +0800 From: "Sean Qiu" To: dev@harmony.apache.org Subject: Re: [classlib][luni] Complement the Missing TimeZone IDs In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Virus-Checked: Checked by ClamAV on apache.org +1 lazy initialization. 2008/6/3 Jim Yu : > Hi all, > > If we run a simple comparison of RI's time zone IDs with Harmony's, we will > find there are quite a few in the same category. > I suggest that we need to complement the missing TimeZone IDs. Two solutions > in my mind: > > [1] We load the TimeZone IDs into available zones cache via ICU completely > and don't use the available zones initialized by TimeZones > any more. But for this solution, many testcase will fail since they based on > the behavior of those TimeZone instances initialized by > TimeZones. So we need to check each failure testcase and identify which > behavior is more reasonable, instances of TimeZones or > those of ICU? > > [2] We just do a small trick. When there is a missing TimeZone ID > which exists in ICU, we add it into available zones cache in TimeZone. > So it will be found from now on. For this solution, almost all the testcase > will succeed since instances of TimeZones are still working. > > I think [2] is a simple fix, although [1] is also reasonable since we can > totally delegate to ICU. Personally I'd go with [2]. > > -- > Best Regards, > Jim, Jun Jie Yu > > China Software Development Lab, IBM > -- Best Regards Sean, Xiao Xia Qiu China Software Development Lab, IBM