Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 37520 invoked from network); 3 Jun 2008 12:00:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jun 2008 12:00:46 -0000 Received: (qmail 12517 invoked by uid 500); 3 Jun 2008 12:00:47 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 12490 invoked by uid 500); 3 Jun 2008 12:00:47 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 12458 invoked by uid 99); 3 Jun 2008 12:00:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 05:00:47 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of alexei.zakharov@gmail.com designates 209.85.146.182 as permitted sender) Received: from [209.85.146.182] (HELO wa-out-1112.google.com) (209.85.146.182) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 11:59:58 +0000 Received: by wa-out-1112.google.com with SMTP id j5so998452wah.18 for ; Tue, 03 Jun 2008 05:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=yHZKNyPbvybA1EsEHmbL6JGy3S5t+MtnV+JnkNxCb+8=; b=o9OVGcSTH2HboKn8ziBsOUb9YIRqSeFFnuF+sxbdV5CsUjVeKBC4StqMB80k1d0wGZ71fcsD8dIWixatObC0eZpM8vgdQxzCvBUgct2Ohlw/GgAExhUSwBnsRZRzULW0kagbi7Rt8R1Q6Tph0N0GULR1RUsZI2HPANH1P+WXg3A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=wkbjmsO1DDkNvLJaOdwXc9TzJpaBZCiUkUQxLEYhOoX4wPPgbv1J4Ka1qRzGmcTGuYH2yQieDTZABX4/jNpPboeDBuAbYo9XNCwi7D3pi7aH+s+N2cD37hJqgJZLaGZzgiD1Kv3iry8zLANuaVroqeqTIXlKHJYXapkwEZjPDAk= Received: by 10.114.201.1 with SMTP id y1mr5478189waf.93.1212494415280; Tue, 03 Jun 2008 05:00:15 -0700 (PDT) Received: by 10.114.13.8 with HTTP; Tue, 3 Jun 2008 05:00:14 -0700 (PDT) Message-ID: <2c9597b90806030500p16c686bdrc7e130d2b0c9e0c9@mail.gmail.com> Date: Tue, 3 Jun 2008 16:00:14 +0400 From: "Alexei Zakharov" To: dev@harmony.apache.org Subject: Re: [classlib][luni] Complement the Missing TimeZone IDs In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Virus-Checked: Checked by ClamAV on apache.org If the search for the missing TimeZone is not very expensive I vote for [2] too. Thanks, Alexei 2008/6/3 Jim Yu : > Hi all, > > If we run a simple comparison of RI's time zone IDs with Harmony's, we will > find there are quite a few in the same category. > I suggest that we need to complement the missing TimeZone IDs. Two solutions > in my mind: > > [1] We load the TimeZone IDs into available zones cache via ICU completely > and don't use the available zones initialized by TimeZones > any more. But for this solution, many testcase will fail since they based on > the behavior of those TimeZone instances initialized by > TimeZones. So we need to check each failure testcase and identify which > behavior is more reasonable, instances of TimeZones or > those of ICU? > > [2] We just do a small trick. When there is a missing TimeZone ID > which exists in ICU, we add it into available zones cache in TimeZone. > So it will be found from now on. For this solution, almost all the testcase > will succeed since instances of TimeZones are still working. > > I think [2] is a simple fix, although [1] is also reasonable since we can > totally delegate to ICU. Personally I'd go with [2]. > > -- > Best Regards, > Jim, Jun Jie Yu > > China Software Development Lab, IBM >