harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: My first submission! java.lang.ThreadLocal
Date Wed, 25 Jun 2008 11:40:18 GMT
Aleksey Shipilev wrote:
> Please see the updated patch [1]. I had solved the NPE issue by
> checking currentThread() result - that's odd but can be considered a
> workaround.
> LUNI tests are ok, DRLVM build is ok, 8x speedup on MT/ThreadLocalBench.

Looking at it now.  I'm going to rearrange the files a bit to put 
ThreadLocal into the DRLVM's kernel classes so that the IBM VME keeps 
working (as I mentioned earlier).

I see this comment in the ThreadLocal.java file:
/* Thanks to Josh Bloch and Doug Lea for code reviews and impl advice. */

am I right in thinking this was just design level discussion?  If Josh 
or Doug contributed directly to the code we'll have to get their 
approval to have it Apache Licensed.


View raw message