harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [classlib][luni] java/util/HashMap.java bug waiting to happen?
Date Wed, 18 Jun 2008 13:23:16 GMT
Endre StĂžlsvik wrote:
> Tony Wu wrote:
> 
>> It's not a public API and I can not imagine that it will be used by
>> other classes/methods in the fufture. If the second condition were
>> reached one day, there might be something wrong with its caller rather
>> than this method. IMO I would remove the redundant condition in the
>> loop.
> 
> Agree .. and throw in a small comment for good measure.

Done at r669164.

I see this as simply removing redundant code, since as others said if 
the null test causes the loop to exit safely you get a NPE on the next 
line anyway.

Regards,
Tim

Mime
View raw message