Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of alexei.fedotov@gmail.com
 designates 209.85.200.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=NHvfHGNOs9cvJ93bRNWfUEo8lvwjqH8rLAn+jvewb3YoozWD5dmkNvQtnHaOlFSPoPfpfOmxH6YcP42Vn+27Tj1Ea9XDMs5NvtLvn7d1aaRB6viskwh0wwRVZXHCygpt0GHEDlhaAmkCKzGP9rnlRJgUZJEK+MraAuZJ9RFAAKk=
Message-ID: <c30d70960805080416w691bd8f6y39ee01d0bef49059@mail.gmail.com>
Date: Thu, 8 May 2008 15:16:15 +0400
From: "Alexei Fedotov" <alexei.fedotov@gmail.com>
To: dev@harmony.apache.org
Subject: Re: RasterTest failure fixed
In-Reply-To: <61d2e9b20805080341m56e34edds5921093922262fd6@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <61d2e9b20805080341m56e34edds5921093922262fd6@mail.gmail.com>

Tharindu, thanks for your effort.

I believe the buffer was intentionally small, see [1]. When the buffer
was small, the expected ArrayIndexOutOfBoundsException was not thrown,
was it?

Thanks.

[1] https://issues.apache.org/jira/browse/HARMONY-2875

On Thu, May 8, 2008 at 2:41 PM, Mackie Mathew <mccloud35@gmail.com> wrote:
> RasterTest was failing because testGetPixels was failing. I was able to pass
>  the test with the following modfications:
>
>  public void testGetPixels() {
>         // Regression test for HARMONY-2875
>         try {
>             Raster raster = Raster.createRaster(new BandedSampleModel(1, 2,
>  3, 4),
>                     new DataBufferByte(new byte[191], *6)*,
>                     new Point(new Point(28, 43)));
>
>             raster.getPixels(6,
>                     Integer.MAX_VALUE, 1, 0, new int[] {});
>             fail("ArrayIndexOutOfBoundsException should be thrown");
>  //$NON-NLS-1$
>         } catch (ArrayIndexOutOfBoundsException e) {
>             // expected
>         }
>
>
>  The test was failing  because the DataBuffer size was too small. When it was
>  increased from 5 to 6, the test passed. Is this fix acceptable?
>  --
>  Regards,
>
>  Tharindu
>


-- 
With best regards,
Alexei