Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of mccloud35@gmail.com
 designates 209.85.146.182 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=tsBKJcpwYzYzo81U0myZ6+CVMMfO/c7q2BxQ0p5+LqXO9e9Pl4dCMfV1M++8qoTk2iDpU4JzfXSAhHogmD2QD/VBtpZgIHIz3adhIXBG5cBjfF0SV/Gt2aiN8A8SCUhcUsUvbCYBO0P5oCwjzaCEb/E7WnaPuumI746B7zDbGoY=
Message-ID: <61d2e9b20805080541q5a6a6b35t9f78e4ed625ee2d@mail.gmail.com>
Date: Thu, 8 May 2008 18:11:06 +0530
From: "Mackie Mathew" <mccloud35@gmail.com>
To: dev@harmony.apache.org
Subject: Re: RasterTest failure fixed
In-Reply-To: <c30d70960805080416w691bd8f6y39ee01d0bef49059@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_25_19113958.1210250466897"
References: <61d2e9b20805080341m56e34edds5921093922262fd6@mail.gmail.com>
	 <c30d70960805080416w691bd8f6y39ee01d0bef49059@mail.gmail.com>

------=_Part_25_19113958.1210250466897
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

I went through that before the change. When the buffer is small a
RastorException: Data Buffer too small is thrown, which prevents the
expected ArrayIndexOutOfBoundsException from being thrown. But when the Data
Buffer's size is increased the expected exception is thrown.

If I'm not mistaken the purpose of this test is to test getPixels() function
with the Integer.MAX_VALUE, as mentioned in [1], not the Data Buffer size.

On Thu, May 8, 2008 at 4:46 PM, Alexei Fedotov <alexei.fedotov@gmail.com>
wrote:

> Tharindu, thanks for your effort.
>
> I believe the buffer was intentionally small, see [1]. When the buffer
> was small, the expected ArrayIndexOutOfBoundsException was not thrown,
> was it?
>
> Thanks.
>
> [1] https://issues.apache.org/jira/browse/HARMONY-2875
>
> On Thu, May 8, 2008 at 2:41 PM, Mackie Mathew <mccloud35@gmail.com> wrote:
> > RasterTest was failing because testGetPixels was failing. I was able to
> pass
> >  the test with the following modfications:
> >
> >  public void testGetPixels() {
> >         // Regression test for HARMONY-2875
> >         try {
> >             Raster raster = Raster.createRaster(new BandedSampleModel(1,
> 2,
> >  3, 4),
> >                     new DataBufferByte(new byte[191], *6)*,
> >                     new Point(new Point(28, 43)));
> >
> >             raster.getPixels(6,
> >                     Integer.MAX_VALUE, 1, 0, new int[] {});
> >             fail("ArrayIndexOutOfBoundsException should be thrown");
> >  //$NON-NLS-1$
> >         } catch (ArrayIndexOutOfBoundsException e) {
> >             // expected
> >         }
> >
> >
> >  The test was failing  because the DataBuffer size was too small. When it
> was
> >  increased from 5 to 6, the test passed. Is this fix acceptable?
> >  --
> >  Regards,
> >
> >  Tharindu
> >
>
>
>
> --
> With best regards,
> Alexei
>


-- 
Regards,

Tharindu

------=_Part_25_19113958.1210250466897--