Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 94768 invoked from network); 22 Apr 2008 10:35:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Apr 2008 10:35:31 -0000 Received: (qmail 81359 invoked by uid 500); 22 Apr 2008 10:35:30 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 81332 invoked by uid 500); 22 Apr 2008 10:35:30 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 81321 invoked by uid 99); 22 Apr 2008 10:35:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Apr 2008 03:35:30 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of alexei.fedotov@gmail.com designates 209.85.146.183 as permitted sender) Received: from [209.85.146.183] (HELO wa-out-1112.google.com) (209.85.146.183) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Apr 2008 10:34:47 +0000 Received: by wa-out-1112.google.com with SMTP id k22so4299438waf.18 for ; Tue, 22 Apr 2008 03:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=rvPc+sKn5u/s3nvugpzeMOHqKQO+CNv1nW0trJ0iZdw=; b=o9VUTk4+8kJ6mxNwTQv9na/hmpVZD1L1HBRs7GEf8RF/QzPXAq9iMCEMvfkn15m2vmx0Xvt/5fbQ6Po3tkUfGmx+ptGnZLMiZouw1FY6Kw5h9/aR6bkqAH3g8ALsrEj/33WgyEsdiK2OgmFcwfusqduVvVhc7gwyLJE/JMR9aZs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=h/dzFDb7FDRtLC0WGrfwM2MDyNfObZdw9zjY1zA5FG6HmWlJpKfSn1s1+DmFWvFMeCehavFKOi1I8wjaX9kZJTxWVpYHD5C3YjOYKjEbNsYdRhYZPTYQguZSnF91SrrgB2VfTLXyIIuQnAUm2xuhFjgXvT2DMv1t9jz8Lf4dQdA= Received: by 10.114.102.1 with SMTP id z1mr35409wab.56.1208860500586; Tue, 22 Apr 2008 03:35:00 -0700 (PDT) Received: by 10.114.92.17 with HTTP; Tue, 22 Apr 2008 03:35:00 -0700 (PDT) Message-ID: Date: Tue, 22 Apr 2008 14:35:00 +0400 From: "Alexei Fedotov" To: dev@harmony.apache.org Subject: Re: [classlib][archive] Parsing invalid manifest (was: Re: classlib archive changed broke EUT/update) In-Reply-To: <480DBDF7.2060504@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <587698b80804170142x29028cb6vc2a8869832d9e0c3@mail.gmail.com> <48085A1B.2030603@gmail.com> <587698b80804180145j7e90557dwb327e1b66acd52a6@mail.gmail.com> <3b3f27c60804180925v602c5799hc116ca6a1ba8a0d9@mail.gmail.com> <480DBDF7.2060504@gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org Hello Tim, I believe it worth considering a kludge after a problematic app manifests itself. Thanks. On Tue, Apr 22, 2008 at 2:29 PM, Tim Ellison wrote: > Even though the manifest is invalid according to the spec, shouldn't we be > parsing it the same way as the RI for compatibility reasons? > > I wonder how many apps have invalid manifests. > > Regards, > Tim > > Nathan Beyer wrote: > > > Careful, the test isn't necessarily invalid - that's quick assumption. It > > needs to be verified that the test isn't dyanamically generating a > manifest > > with Harmony's classlib; it's possible that Harmony's classlib is creating > > the invalid manifest, which later causes a failure when reading the > > manifest. > > > > -Nathan > > > > On Fri, Apr 18, 2008 at 3:45 AM, Vladimir Beliaev < > > vladimir.k.beliaev@gmail.com> wrote: > > > > > > > According to the issue quick evaluation the tests are invalid, so noted > > > revision helped to detect them. The tests are to be excluded now. > > > > > > Tim, Alexei, thank you for your input. > > > > > > Thanks > > > Vladimir > > > > > > 2008/4/18, Alexei Fedotov > > > > > > > > : > > > > > > > > Tim, > > > > We are sorting that out. > > > > > > > > Thanks. > > > > > > > > On Fri, Apr 18, 2008 at 12:21 PM, Tim Ellison > > > > > > > > > wrote: > > > > > > > > > It'll be a couple of days before I can look at it as I'm going away. > > > > > > > > > I'll > > > > > > > > > take a look when I get back if nobody beats me to it. > > > > > > > > > > Regards, > > > > > Tim > > > > > > > > > > > > > > > > > > > > Vladimir Beliaev wrote: > > > > > > > > > > > > > > > > Tim, > > > > > > > > > > > > I've opened > > > > > > > > > > > HARMONY-5747 > > > > > > > > > > > which > > > > > > reports regression in EUT/update suite due to r641928 > > > > > > > > > > > > [apply patch > > > > > > HARMONY-4569 > > > > > > ([classlib][performance] > > > > > > Ineffecient manifest parsing results in slowdown when debugging > java > > > > > > > > > > > code)] > > > > > > > > > > > Could you take a look at regression & get it resolved, please? > > > > > > > > > > > > Thanks > > > > > > Vladimir > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > With best regards, > > > > Alexei > > > > > > > > > > > > > > > > -- With best regards, Alexei