Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (nike.apache.org: domain of sergey.i.salishev@gmail.com
 designates 74.125.46.156 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=HiIP4YFykboZg67Lf1FluOAuW7hrLB0WQfzmpRBstOgZuh8EFvmMvIsqXWh8fmbpPcImSh8Ttgtd3OAqd3/9h9RU95Rq05DYvePnsrps1j8OujGySjnnanppDu9z+MR3jgUSUKg9YUQSeR6VMuswezygH6oqzDFSqMeFK/nR8p8=
Message-ID: <728dc7fa0804180946y4a2ba333m9e7bba043b2942e@mail.gmail.com>
Date: Fri, 18 Apr 2008 20:46:34 +0400
From: "Sergey Salishev" <sergey.i.salishev@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib][luni][performance] Improvements in Collections
In-Reply-To: <3b3f27c60804180913h214d861eqb4b937768d3b0bbf@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_2562_27897115.1208537194271"
References: <4bebff790804172350r15419dd4v95e9c7a7adb8f14d@mail.gmail.com>
	 <3b3f27c60804180913h214d861eqb4b937768d3b0bbf@mail.gmail.com>

------=_Part_2562_27897115.1208537194271
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Nathan,

I don't think anyone will notice the hash map size rounding. It can lead to
some memory overhead in very rare cases the user creates hash map with the
exact size. But in the most common case where the map is created with
default size the rounding will not change the behavior at all as it's in
agreement with the standard 2x growth policy. On the other hand size
rounding gives substantial performance boost on all gets.

Thanks.
Sergey.


On Fri, Apr 18, 2008 at 8:13 PM, Nathan Beyer <ndbeyer@apache.org> wrote:

> https://issues.apache.org/jira/browse/HARMONY-5718
>
> Again, I don't agree with the capacity rounding in the patch attached to
> this issue. I do like the change to the internal data structure; use two
> arrays for key/value instead a single array. It makes the code easier to
> read.
>
> -Nathan
>
> On Fri, Apr 18, 2008 at 1:50 AM, Aleksey Shipilev <
> aleksey.shipilev@gmail.com> wrote:
>
>  > Colleagues,
> >
> > I had recently filed two JIRAs with improvements in Collections,
> > giving up to +30-40% to serialization benchmarks. Presumably they will
> > boost the performance across the all users since the optimization is
> > pretty general:
> > https://issues.apache.org/jira/browse/HARMONY-5761
> > https://issues.apache.org/jira/browse/HARMONY-5718
> >
> > Would some classlib guru (Tim, Nathan, Tony?) review and commit them?
> >
> > Thanks,
> > Aleksey.
> >
>

------=_Part_2562_27897115.1208537194271--