Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of aleksey.shipilev@gmail.com
 designates 64.233.166.183 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=lf7T5MkAf7zmUBb9myRs5HWE8Mjrw33lf+tFRQsjBmBhwIW/U7hHoCZo2aBX/uDHwyulxOEaSriTIUmc//Out0mPXDVmJwO6bmxYmPtPLvCEzljOPnFcLGAPJopYtlXXwJIhyXcHO1n4mF/I7yuAU3K8N+cIZzEsDzLRxrIOU/E=
Message-ID: <4bebff790804300119n7c442604p612e84785d61069d@mail.gmail.com>
Date: Wed, 30 Apr 2008 12:19:07 +0400
From: "Aleksey Shipilev" <aleksey.shipilev@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib][luni][performance] *HashMap cleanup and optimization
 (was: Re: [classlib][luni][performance] IdentityHashMap implementation)
In-Reply-To: <3b3f27c60804291721u897f98fo243fb52cde9e67b9@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4bebff790804240845n10e307f3uffce5749accc849b@mail.gmail.com>
	 <E1Jp7Au-0005GE-CK@fhw-relay07.plus.net>
	 <4bebff790804241431m282af26fxed0eeab1fbd2147c@mail.gmail.com>
	 <4bebff790804280203g60797858u7eaa7dfa069bd215@mail.gmail.com>
	 <4bebff790804282349y61180e92l45c122b4919e8a13@mail.gmail.com>
	 <3b3f27c60804291721u897f98fo243fb52cde9e67b9@mail.gmail.com>

Nathan,

Is there an option to commit this patch before code freeze starts (if
not already)?
The changes there are pretty trivial and I could proceed with
IdentityHashMap works while M6 is under testing.

Thanks,
Aleksey.

On Wed, Apr 30, 2008 at 4:21 AM, Nathan Beyer <ndbeyer@apache.org> wrote:
> Bring this back up after the milestone is complete.
>
>  -Nathan
>
>  On Tue, Apr 29, 2008 at 1:49 AM, Aleksey Shipilev <
>
> aleksey.shipilev@gmail.com> wrote:
>
>
> > Hi,
>  >
>  > > I see the plan is following:
>  > >  1. Sweep the HashMap implementation and make the source beatuful: add
>  > > necessary comments, re-layout class members.
>  > >  2. Test-commit-test sweeped HashMap implementation and see there are
>  > > no breakages.
>  > >  3. Remove legacy IdentityHashMap and copy HashMap over it (using svn
>  > > capabilities)
>  > >  4. Transform new IdentityHashMap to real IdentityHashMap (hashCode ->
>  > > identityHashCode, equals -> == and stuff)
>  > >  5. Test-commit-test new IdentityHashMap.
>  >
>  > It seems like we had stuck on (1) point on our plan, there is a patch
>  > already in HARMONY-5791, and we need to review it before moving
>  > towards actual performance  works. LUNI/Collections gurus (Jimmy,
>  > Mark, Nathan, Tim?), please review it so I can proceed in my efforts.
>  > :)
>  >
>  > Thanks,
>  > Aleksey.
>  >
>  >
>  > On Mon, Apr 28, 2008 at 1:03 PM, Aleksey Shipilev
>  > <aleksey.shipilev@gmail.com<https://mail.google.com/mail?view=cm&tf=0&to=aleksey.shipilev@gmail.com>>
>
> > wrote:
>  > > Hi again,
>  > >
>  > >  Can some classlib guru review HARMONY-5791?
>  > >
>  > >  Thanks,
>  > >  Aleksey.
>  > >
>  > >  On Fri, Apr 25, 2008 at 1:31 AM, Aleksey Shipilev
>  > >
>  > >
>  > > <aleksey.shipilev@gmail.com<https://mail.google.com/mail?view=cm&tf=0&to=aleksey.shipilev@gmail.com>>
>
>
> > wrote:
>  > >  > Mark,
>  > >  >
>  > >  >  That's great there are no regressions on Commons-collections tests!
>  > >  >  BTW, can we adopt them as the part of BTI or luni tests?
>  > >  >
>  > >  >  I had created HARMONY-5791 for HashMap cleanup, and there's a first
>  > >  >  patch already, can you please take a look? I had extracted the
>  > >  >  contract-related methods there, so the change to IdentityHashMap
>  > >  >  should be pretty straightforward. After we finish with this issue, I
>  > >  >  could provide the clean script/patch for IdentityHashMap changes.
>  > >  >
>  > >  >  Thanks,
>  > >  >  Aleksey.
>  > >  >
>  > >  >
>  > >  >
>  >
>