harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: svn commit: r648367 - /harmony/enhanced/drlvm/trunk/vm/tests/kernel/java/lang/reflect/MethodTest.java
Date Wed, 16 Apr 2008 08:26:58 GMT
2008/4/16, Vasily Zakharov <vmz@apache.org>:
> Alexey,
>
> I've investigated the issue and found it's not a bug, but a
> consequence of actual lack of stack for this test to pass on
> Windows-64 on Interpreter.
>
> So my first target was to eliminate a false negative in the regular test runs.
>
> Now I'm working on moving the test to regression test suite that
> provides the capability to specify an increased stack size for the
> particular test.

Sounds good, thanks!

>
> Vasily
>
>
>
> On Wed, Apr 16, 2008 at 8:54 AM, Alexey Varlamov
> <alexey.v.varlamov@gmail.com> wrote:
> > Vasily,
> >  Don't you find this is a bad way to fix failures?
> >  Please consider alternatives, e.g. separating the testcase and
> >  excluding it on problem platform.
> >  --
> >  Alexey
> >
> >  2008/4/16, vmz@apache.org <vmz@apache.org>:
> >
> >
> > > Author: vmz
> >  > Date: Tue Apr 15 11:37:22 2008
> >  > New Revision: 648367
> >  >
> >  > URL: http://svn.apache.org/viewvc?rev=648367&view=rev
> >  > Log:
> >  > HARMONY-5622 [drlvm][kernel][geronimo] Method.getGeneric*() methods throw
NPE for parametrized interface methods
> >  > Removed regression test from kernel tests, as it causes the acceptance test
failure:
> >  > StackOverflowError occurs on Windows/x86/64/Interpreter due to extensive stack
use.
> >  >
> >  > Modified:
> >  >    harmony/enhanced/drlvm/trunk/vm/tests/kernel/java/lang/reflect/MethodTest.java
> >  >
> >  > Modified: harmony/enhanced/drlvm/trunk/vm/tests/kernel/java/lang/reflect/MethodTest.java
> >  > URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/tests/kernel/java/lang/reflect/MethodTest.java?rev=648367&r1=648366&r2=648367&view=diff
> >  > ==============================================================================
> >  > --- harmony/enhanced/drlvm/trunk/vm/tests/kernel/java/lang/reflect/MethodTest.java
(original)
> >  > +++ harmony/enhanced/drlvm/trunk/vm/tests/kernel/java/lang/reflect/MethodTest.java
Tue Apr 15 11:37:22 2008
> >  > @@ -332,30 +332,4 @@
> >  >             fail("Error2: " + e.toString());
> >  >         }
> >  >     }
> >  > -
> >  > -    interface GenericSample {
> >  > -        public <T extends GenericSample, E extends Throwable> T test(T
param) throws E;
> >  > -    }
> >  > -
> >  > -    /**
> >  > -     *
> >  > -     */
> >  > -    public void test_getGeneric() {
> >  > -        // Regression for HARMONY-5622
> >  > -        Method method = GenericSample.class.getMethods()[0];
> >  > -        for (int i = 0; i < 5; i++) {
> >  > -            switch (i) {
> >  > -            case 0: method.getGenericParameterTypes();
> >  > -                    break;
> >  > -            case 1: method.getGenericReturnType();
> >  > -                    break;
> >  > -            case 2: method.getGenericExceptionTypes();
> >  > -                    break;
> >  > -            case 3: method.getTypeParameters();
> >  > -                    break;
> >  > -            case 4: method.toGenericString();
> >  > -                    break;
> >  > -            }
> >  > -        }
> >  > -    }
> >  >  }
> >  >
> >  >
> >  >
> >
>

Mime
View raw message