harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Fedotov" <alexei.fedo...@gmail.com>
Subject Re: [classlib][archive] Parsing invalid manifest (was: Re: classlib archive changed broke EUT/update)
Date Tue, 22 Apr 2008 22:32:16 GMT
Tim,
You have a fantastic intuition (or the odds are unfair to me).

site$ ant -d
     [echo]        #######################################################
     [echo]        #
     [echo]        #  Now using Anakia to transform our XML documentation
     [echo]        #  to HTML.
     [echo]        #
     [echo]        #######################################################
Exception reading component harmony\site\lib\commons-collections.jar
(reason: Missing version attribute: Manifest-Version)

Please find the patch at HARMONY-5778 [1]
Thanks!

[1] https://issues.apache.org/jira/browse/HARMONY-5778

On Tue, Apr 22, 2008 at 2:35 PM, Alexei Fedotov
<alexei.fedotov@gmail.com> wrote:
> Hello Tim,
>  I believe it worth considering a kludge after a problematic app
>  manifests itself.
>
>  Thanks.
>
>
>
>  On Tue, Apr 22, 2008 at 2:29 PM, Tim Ellison <t.p.ellison@gmail.com> wrote:
>  > Even though the manifest is invalid according to the spec, shouldn't we be
>  > parsing it the same way as the RI for compatibility reasons?
>  >
>  >  I wonder how many apps have invalid manifests.
>  >
>  >  Regards,
>  >  Tim
>  >
>  >  Nathan Beyer wrote:
>  >
>  > > Careful, the test isn't necessarily invalid - that's quick assumption. It
>  > > needs to be verified that the test isn't dyanamically generating a
>  > manifest
>  > > with Harmony's classlib; it's possible that Harmony's classlib is creating
>  > > the invalid manifest, which later causes a failure when reading the
>  > > manifest.
>  > >
>  > > -Nathan
>  > >
>  > > On Fri, Apr 18, 2008 at 3:45 AM, Vladimir Beliaev <
>  > > vladimir.k.beliaev@gmail.com> wrote:
>  > >
>  > >
>  > > > According to the issue quick evaluation the tests are invalid, so noted
>  > > > revision helped to detect them. The tests are to be excluded now.
>  > > >
>  > > > Tim, Alexei, thank you for your input.
>  > > >
>  > > > Thanks
>  > > > Vladimir
>  > > >
>  > > > 2008/4/18, Alexei Fedotov
>  > <alexei.fedotov@gmail.com<https://mail.google.com/mail?view=cm&tf=0&to=alexei.fedotov@gmail.com>
>  > > >
>  > > > > :
>  > > > >
>  > > > > Tim,
>  > > > > We are sorting that out.
>  > > > >
>  > > > > Thanks.
>  > > > >
>  > > > > On Fri, Apr 18, 2008 at 12:21 PM, Tim Ellison
>  > <t.p.ellison@gmail.com<https://mail.google.com/mail?view=cm&tf=0&to=t.p.ellison@gmail.com>
>  > > > >
>  > > > > wrote:
>  > > > >
>  > > > > > It'll be a couple of days before I can look at it as I'm going
away.
>  > > > > >
>  > > > > I'll
>  > > > >
>  > > > > > take a look when I get back if nobody beats me to it.
>  > > > > >
>  > > > > >  Regards,
>  > > > > >  Tim
>  > > > > >
>  > > > > >
>  > > > > >
>  > > > > >  Vladimir Beliaev wrote:
>  > > > > >
>  > > > > >
>  > > > > > > Tim,
>  > > > > > >
>  > > > > > > I've opened
>  > > > > > >
>  > > > > > HARMONY-5747<https://issues.apache.org/jira/browse/HARMONY-5747>
>  > > > > >
>  > > > > > > which
>  > > > > > > reports regression in EUT/update suite due to r641928
>  > > > > > >
>  > > > > > >      [apply patch
>  > > > > > > HARMONY-4569<https://issues.apache.org/jira/browse/HARMONY-4569>
>  > > > > > > ([classlib][performance]
>  > > > > > > Ineffecient manifest parsing results in slowdown when
debugging
>  > java
>  > > > > > >
>  > > > > > code)]
>  > > > > >
>  > > > > > > Could you take a look at regression & get it resolved,
please?
>  > > > > > >
>  > > > > > > Thanks
>  > > > > > > Vladimir
>  > > > > > >
>  > > > > > >
>  > > > > > >
>  > > > > >
>  > > > >
>  > > > >
>  > > > > --
>  > > > > With best regards,
>  > > > > Alexei
>  > > > >
>  > > > >
>  > > >
>  > >
>  > >
>  >
>
>
>
>  --
>  With best regards,
>  Alexei
>



-- 
With best regards,
Alexei

Mime
View raw message