harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Fedotov" <alexei.fedo...@gmail.com>
Subject Re: [general] icu or apr-iconv, which coding library is better?
Date Sun, 13 Apr 2008 09:17:06 GMT
Hello Nathan,
Thanks for questions.

There are many other places where charset (en/de)coders are used, but
we use icu4c there. HARMONY-5692 is a replacement of log4cxx with
custom logger and removing dependent aprutil and apr-iconv which are
not used any longer after this replacement.
   * The replacement decreases
windows_x86_msvc_debug/deploy/jdk/jre/bin/default/harmonyvm.dll size
from 4079616 to 2961408. This would probably improve a startup time.
   * The custom logger requires less lines of code than a log4cxx
wrapper, hence, is easier to maintain.
   * By specification VM logging should be done using provided
vfprintf. C++ logger adds two layers of conversion. vfprintf layer wan
not implemented, and implementing it would increase a number of
wrappers for log4cxx.

Please, let me know if these arguments are enough for log4cxx being removed.

Note, apr itself remains, and it is pretty good piece of code to my
perception. I do not intend to invent pools or OS call wrappers. We
throw away the staff guys from apr does not allow to put into their
main module. :-)

On Sun, Apr 13, 2008 at 12:30 AM, Nathan Beyer <nbeyer@gmail.com> wrote:
> Huh? This post doesn't sound like anything in HARMONY-5692. We need
>  clear somethings up first.
>  1. apr-iconv is in the build as a dependency of log4cxx
>  2. there is no use of apr-iconv for charset encoding/decoding
>  3. HARMONY-5692, AFAIU is replacement of log4cxx with custom logger
>  implementation to reduce the build time
>  What's the value of replacing log4cxx with a custom logger? Reducing
>  the build time isn't enough for me - there have to be other ways to
>  accomplish that without sub-system replacement.
>  -Nathan
>  On Fri, Apr 11, 2008 at 10:37 PM, Alexei Fedotov
>  <alexei.fedotov@gmail.com> wrote:
>  > Hello,
>  >
>  >  One may notice that both icu and apr-iconv are currently used to build
>  >  Harmony HDK. Both libraries address charset encoding and decoding.
>  >  Should we keep both of them or try to use the only one?
>  >
>  >  HARMONY-5692 [1] contains one possible "compilable" answer to this
>  >  question and related reasoning. Alexey Varlamov and Tim suggested
>  >  discussing the matters on dev@ list, so I created this thread on the
>  >  subject. You are welcome to share your opinion about the libraries
>  >  Harmony depends on, the patch from [2], my arguments defending the
>  >  patch, and further directions here.
>  >
>  >  --
>  >  With best regards,
>  >  Alexei
>  >
>  >  [1] https://issues.apache.org/jira/browse/HARMONY-5692
>  >

With best regards,

View raw message