harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao-Feng Li" <xiaofeng...@gmail.com>
Subject Re: [general] removing people names from sources
Date Mon, 21 Apr 2008 13:45:13 GMT
Hmm, it's all about the committer's decision to add or remove any name
in the files he/she modifies. If Alexei had his reason to remove the
author names from those files, I have no problem. :-)  I should have
clarified that, my objection is against making the name removal a rule
to the community, while I don't object to any people's own decision,
which I also respect. :)

Thanks,
xiaofeng

On Mon, Apr 21, 2008 at 9:30 PM, Mark Hindess
<mark.hindess@googlemail.com> wrote:
>
>  On 21 April 2008 at 20:48, "Xiao-Feng Li" <xiaofeng.li@gmail.com> wrote:
>  > Hi, sorry for being different here.
>  >
>  > I strongly object to remove author names without any reason, although
>  > I don't mind removing myself's name. They put the names in their
>  > original code for their own reasons, it's not other people's right to
>  > remove their names without any reason.
>
>  But that is what is happening.  For example, Alexei Fedotov's patch
>  for HARMONY-5692 includes several changes like:
>
>  --- harmony/enhanced/drlvm/trunk/vm/interpreter/src/interp_exports.cpp
>  +++ harmony/enhanced/drlvm/trunk/vm/interpreter/src/interp_exports.cpp
>  @@ -14,10 +14,6 @@
>   *  See the License for the specific language governing permissions and
>   *  limitations under the License.
>   */
>  -/**
>  - * @author Ivan Volosyuk
>  - * @version $Revision: 1.23.20.3 $
>  - */
>   #include <stdlib.h>
>   #include <stdio.h>
>   #include "open/types.h"
>
>  with *no* other changes to the source file(s), or things like:
>
>  --- harmony/enhanced/drlvm/trunk/vm/vmcore/include/lock_manager.h
>  +++ harmony/enhanced/drlvm/trunk/vm/vmcore/include/lock_manager.h
>  @@ -14,13 +14,8 @@
>   *  See the License for the specific language governing permissions and
>   *  limitations under the License.
>   */
>  -/**
>  - * @author Andrey Chernyshev
>  - * @version $Revision: 1.1.2.1.4.4 $
>  - */
>  -
>  -#ifndef _lock_manager_H_
>  -#define _lock_manager_H_
>  +#ifndef _LOCK_MANAGER_H
>  +#define _LOCK_MANAGER_H
>
>   #include "open/hythread_ext.h"
>   #include "open/types.h"
>  @@ -65,4 +60,4 @@
>
>   #endif // __cplusplus
>
>  -#endif // _lock_manager_H_
>  +#endif /* _LOCK_MANAGER_H */
>
>  where the changes are completely trivial.
>
>  (I'm sure Alexei got permission to remove at least the ones with no
>  changes at all, but for the sake of argument assume he did not.)
>
>  Are either of these fair/unfair?  Is a trivial change enough to warrant
>  removal (or adding your own name)?  What is trivial and what is not?
>
>  I don't want to be the judge so I'd prefer to avoid any potential
>  unfairness by removing them all.  The public history of the project
>  has the information for anyone who cares to look.
>
>  -Mark.
>
>
>



-- 
http://xiao-feng.blogspot.com

Mime
View raw message