harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [classlib][performance] @Inline and @NoBoundsCheck annotation support
Date Tue, 29 Apr 2008 11:25:57 GMT
Aleksey Shipilev wrote:
> On Tue, Apr 29, 2008 at 12:22 PM, Tim Ellison <t.p.ellison@gmail.com> wrote:
>>> Should we care about user code and support
>>> @Inline pragma originating from any package user wants?
>>>
>>  I wouldn't prevent people from adding @Inline to their application methods
>> if they choose to do so.  But I would prevent @NoBoundsCheck of course for
>> any classes not loaded by the bootstrap class loader.
> 
> I mean here that annotation is a class, presumably will be placed in
> o.a.h.luni.annotations.*. There are two options for us:
>  1. We favor only @Inline annotation coming from
> o.a.h.luni.annotations.*. That's the simplest way but it would require
> for user that wants to use this annotation to import o.a.h package.

I vote for this option, since then there is no ambiguity about what the 
annotation means (because we can define it precisely), and we can refine 
it with parameters etc as we see fit.

Regards,
Tim

>  2. We can handle all @Inline annotations coming from any package user
> want. Here user may declare it's own annotation in its own package and
> use it. It also would be the generalization point, because we can
> aggregate vmmagic's @Inline annotations here.
> 
> Thanks,
> Aleksey.
> 

Mime
View raw message