harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: svn:ignore properties update
Date Tue, 15 Apr 2008 21:32:18 GMT
Gregory Shimansky wrote:
> On 16 April 2008 Alexey Petrenko wrote:
>> 2008/4/16, Gregory Shimansky <gshimansky@apache.org>:
>>> On 16 April 2008 Alexey Petrenko wrote:
>>>> 2008/4/16, Tim Ellison <t.p.ellison@gmail.com>:
>>>>> Vasily Zakharov wrote:
>>>>>> Don't anyone mind if I add the following files to svn:ignore
>>>>>> properties, so that they don't get in the way when
>>>>>> commiting/creating patches?
>>>>> No objections.
>>>>>
>>>>>> working_vm/junit*.properties
>>>>> Isn't that just an artifact of an interrupted JUnit run?  Probably
>>>>> just delete your file, no need to add to ignore.
>>>> Since these files are result of error then we definitely do not want
>>>> to see them in svn repository. Right?
>>>> If so why don't we want to add the to ignore list?
>>> I think it is better to avoid such errors. When such file appears in your
>>> "svn status" you would know that something didn't go right even if you
>>> didn't notice it right away.
>>> Files added to svn:ignore are files expected to be generated.
>> Why? I think that all the files, which we do not want to see in svn,
>> worths to be added to ignore list.
> 
> -1
> 
> I disagree. Or else we'd add "*" to svn:ignore for all of subdirectories. This 
> makes no sense.
> 
> Only files that are expected to be generated should be ignored. All other 
> files are a warning for the developer that all other developers didn't expect 
> them to appear in the source tree.
> 
> You should want to find files like "junit*.properties" or "core.*" to know 
> that the build doesn't work as expected by all other people.

I agree.  Just name the expected ignores.

Regards,
Tim

Mime
View raw message